Conversation
|
hey there - is this PR functional (apart from breaking backwards compatibility with < 0.6) or still a WIP? |
Member
Author
|
Yeah, it should be more or less semantically equivalent |
plaintextpaco
suggested changes
Feb 15, 2023
| // along with this program. If not, see <http://www.gnu.org/licenses/>. | ||
|
|
||
| pragma solidity >=0.5.0 <0.6.0; | ||
| pragma solidity >=0.6.0; |
There was a problem hiding this comment.
you should set a higher bound, since the contract doesn't compile with solidity 0.8 for example (due to the cast in line 113)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: merging will break backwards compatibility with solc < 0.6.