fix: use protojson camelcase default for wf payload serialization#104
Merged
Conversation
Signed-off-by: Samantha Coyle <sam@diagrid.io>
There was a problem hiding this comment.
Pull request overview
Switches protojson marshaling for workflow payloads from snake_case (UseProtoNames: true) to the default camelCase, aligning proto-typed payloads with Go-struct payloads and standard JSON conventions.
Changes:
- Drop
UseProtoNames: trueintask/executor.goprotoMarshaler. - Drop
UseProtoNames: trueinapi/orchestration.goprotoMarshaler. - Update accompanying doc comments.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| task/executor.go | Use default protojson options (camelCase) for workflow payload marshaling. |
| api/orchestration.go | Use default protojson options (camelCase) for workflow payload marshaling. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
yaron2
approved these changes
May 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
google.protobuf.Struct) now serialize to camelCase JSON — the protojson default and standard JSON wire conventionjsontags; this fixes mixed-case output when both flow through the samemarshalDatahelperWhy
Workflow outputs were producing mixed camelCase/snake_case JSON depending on whether the field originated from a proto type or a Go struct. External consumers (MCP spec, JSON SDKs in other languages) expect camelCase consistently. Defaulting protojson to camelCase aligns proto payloads with that convention.