Add Last to the func name GetActivityByName and GetWorkflowByName & GetLastChildWorkflowByName#105
Merged
Conversation
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
JoshVanL
approved these changes
May 19, 2026
There was a problem hiding this comment.
Pull request overview
Renames two propagation API methods to make the "returns the last match" semantics explicit in their names: GetWorkflowByName → GetLastWorkflowByName and GetActivityByName → GetLastActivityByName. Doc comments and all callers in the tests are updated to match.
Changes:
- Rename
PropagatedHistory.GetWorkflowByNametoGetLastWorkflowByNameandWorkflowResult.GetActivityByNametoGetLastActivityByName, updating doc comments. - Update all test functions and call sites in
api/propagation_test.goto use the new names.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| api/propagation.go | Renames the two singular getters and updates the related doc comments. |
| api/propagation_test.go | Updates test names and call sites to the new method names. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Signed-off-by: Cassandra Coyle <cassie@diagrid.io>
JoshVanL
approved these changes
May 19, 2026
cicoyle
changed the title
3 tasks
siri-varma
added a commit
to siri-varma/java-sdk
that referenced
this pull request
May 20, 2026
Address review feedback on dapr#1739: replace user-facing PropagatedHistoryChunk with WorkflowResult, mirroring dapr/durabletask-go#105. Adds typed ActivityResult and ChildWorkflowResult value types, and getLast*ByName / get*ByName lookups so callers don't walk raw history events. Renames getWorkflowByName to getLastWorkflowByName for symmetry with the new methods. Signed-off-by: Siri Varma Vegiraju <siri.varma@outlook.com>
This was referenced May 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.