[WIP] Adding semantic conv for dapr and trace prop from context#57
Open
salaboy wants to merge 1 commit into
Open
[WIP] Adding semantic conv for dapr and trace prop from context#57salaboy wants to merge 1 commit into
salaboy wants to merge 1 commit into
Conversation
Signed-off-by: salaboy <Salaboy@gmail.com>
salaboy
force-pushed
the
trace-context
branch
from
9a1fcef to
56207d9
Compare
7 tasks
|
is this dead? |
Author
|
@SrChronus I hope not.. I hope someone from the team can take these changes and move them forward @yaron2 @javier-aliaga |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a semantic convention for the Dapr properties that are added into the spans, and remove the concept of durable task attributes.
This also check if the trace parent can be obtained from the Otel context.