Conversation
|
pls resolve the conflicts @seherv |
a9aa525 to
0d90170
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1020 +/- ##
==========================================
- Coverage 86.63% 81.47% -5.16%
==========================================
Files 84 137 +53
Lines 4473 13482 +9009
==========================================
+ Hits 3875 10985 +7110
- Misses 598 2497 +1899 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
b94062b to
34dc7b2
Compare
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
This reverts commit 34dc7b2. Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
PyPI's strict description renderer rejected the previous markup, blocking publish. Caught by a TestPyPI dry-run. - dapr-ext-langgraph, dapr-ext-strands: title underline length matches title - flask_dapr: replace markdown code fence with .. code-block:: python Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
3e0df2b to
a1567d5
Compare
Signed-off-by: Sergio Herrera <627709+seherv@users.noreply.github.com>
| - name: Verify version.py matches tag | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| run: | | ||
| uv run python -c " | ||
| import os | ||
| from dapr.version import __version__ | ||
| tag_version = os.environ['GITHUB_REF'].removeprefix('refs/tags/v') | ||
| assert tag_version == __version__, ( | ||
| f'Tag {os.environ[\"GITHUB_REF\"]!r} expects __version__={tag_version!r}, ' | ||
| f'got {__version__!r}. Bump version files before tagging, see RELEASE.md' | ||
| ) | ||
| " | ||
| - name: Verify release version is not a .dev | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| run: | | ||
| uv run python -c " | ||
| from dapr.version import __version__ | ||
| assert '.dev' not in __version__, ( | ||
| f'__version__ {__version__!r} contains ".dev". Release tags must point to a stable or rc version' | ||
| ) | ||
| " |
There was a problem hiding this comment.
Couldn't these be the same step?
There was a problem hiding this comment.
Pull request overview
Removes the repo’s custom *-dev package publishing mechanism (and the setup.py glue that implemented it), switching to a single root VERSION file + hatchling dynamic versions, and updates docs/workflows so development installs happen directly from git instead of via separate PyPI package names.
Changes:
- Remove per-package
setup.pylogic that rewrote names/versions into*-devbuilds, and stop publishing anything onmain. - Introduce a single root
VERSIONfile and updatepyproject.toml/extensionpyproject.tomlfiles to read versions from it viahatchling. - Update docs and CI checks to align with the new versioning/release process (including tag/version validation and
mainrequiring a.devversion).
Reviewed changes
Copilot reviewed 33 out of 33 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| VERSION | Adds root source-of-truth version string for all packages. |
| setup.py | Removes legacy setuptools build-time renaming for dapr-dev. |
| RELEASE.md | Updates release process docs for tag-only publishing + single VERSION workflow. |
| README.md | Updates install docs to use git-based installs for in-development versions. |
| pyproject.toml | Switches build backend to hatchling and reads version from VERSION; updates mypy config. |
| ext/flask_dapr/setup.py | Removes legacy setuptools build-time renaming for flask-dapr-dev. |
| ext/flask_dapr/README.rst | Fixes README formatting to proper RST code block. |
| ext/flask_dapr/pyproject.toml | Switches to hatchling and reads version from root VERSION. |
| ext/flask_dapr/flask_dapr/version.py | Removes per-package hardcoded version constant. |
| ext/dapr-ext-workflow/setup.py | Removes legacy setuptools build-time renaming for dapr-ext-workflow-dev. |
| ext/dapr-ext-workflow/pyproject.toml | Switches to hatchling and reads version from root VERSION. |
| ext/dapr-ext-workflow/dapr/ext/workflow/version.py | Removes per-package hardcoded version constant. |
| ext/dapr-ext-strands/setup.py | Removes legacy setuptools build-time renaming for dapr-ext-strands-dev. |
| ext/dapr-ext-strands/README.rst | Fixes RST header underline length. |
| ext/dapr-ext-strands/pyproject.toml | Switches to hatchling and reads version from root VERSION. |
| ext/dapr-ext-strands/dapr/ext/strands/version.py | Removes per-package hardcoded version constant. |
| ext/dapr-ext-langgraph/setup.py | Removes legacy setuptools build-time renaming for dapr-ext-langgraph-dev. |
| ext/dapr-ext-langgraph/README.rst | Fixes RST header underline length. |
| ext/dapr-ext-langgraph/pyproject.toml | Switches to hatchling and reads version from root VERSION. |
| ext/dapr-ext-langgraph/dapr/ext/langgraph/version.py | Removes per-package hardcoded version constant. |
| ext/dapr-ext-grpc/setup.py | Removes legacy setuptools build-time renaming for dapr-ext-grpc-dev. |
| ext/dapr-ext-grpc/pyproject.toml | Switches to hatchling and reads version from root VERSION. |
| ext/dapr-ext-grpc/dapr/ext/grpc/version.py | Removes per-package hardcoded version constant. |
| ext/dapr-ext-fastapi/setup.py | Removes legacy setuptools build-time renaming for dapr-ext-fastapi-dev. |
| ext/dapr-ext-fastapi/pyproject.toml | Switches to hatchling and reads version from root VERSION. |
| ext/dapr-ext-fastapi/dapr/ext/fastapi/version.py | Removes per-package hardcoded version constant. |
| dapr/version/version.py | Removes old version constant module previously used by setup.py. |
| dapr/version/init.py | Derives __version__ from installed package metadata. |
| dapr/clients/grpc/subscription.py | Adds mypy suppressions for stream iterator typing. |
| dapr/clients/exceptions.py | Adds mypy suppression for grpc-status typing. |
| .github/workflows/build.yaml | Ensures CI runs on main pushes and asserts main stays on a .dev version. |
| .github/workflows/build-tag.yaml | Adds tag/version assertions and publishes wheels on tags. |
| .github/workflows/build-push-to-main.yaml | Removes workflow that previously published dev snapshots on main. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| from importlib.metadata import version | ||
|
|
||
| __version__ = version('dapr') |
| - name: Verify version.py matches tag | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| run: | | ||
| uv run python -c " | ||
| import os | ||
| from dapr.version import __version__ | ||
| tag_version = os.environ['GITHUB_REF'].removeprefix('refs/tags/v') | ||
| assert tag_version == __version__, ( | ||
| f'Tag {os.environ[\"GITHUB_REF\"]!r} expects __version__={tag_version!r}, ' | ||
| f'got {__version__!r}. Bump version files before tagging, see RELEASE.md' | ||
| ) | ||
| " | ||
| - name: Verify release version is not a .dev | ||
| if: startsWith(github.ref, 'refs/tags/v') | ||
| run: | | ||
| uv run python -c " | ||
| from dapr.version import __version__ | ||
| assert '.dev' not in __version__, ( | ||
| f'__version__ {__version__!r} contains ".dev". Release tags must point to a stable or rc version' |
Description
Removes the
setup.pyfiles that created separate-devbuilds for all packages, and updates docs to instruct users to install directly from source if they need the latest changes in main.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #961
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: