Feature: Fullscreen Video Playback with Interactive Controls#731
Open
Dawnflare wants to merge 19 commits intodarklinkpower:masterfrom
Open
Feature: Fullscreen Video Playback with Interactive Controls#731Dawnflare wants to merge 19 commits intodarklinkpower:masterfrom
Dawnflare wants to merge 19 commits intodarklinkpower:masterfrom
Conversation
…ction-FullScreenVideos
…tly in constructor to fix black screen without breaking play button
…er Play() when starting from paused
…vate field guidelines
…False); add PR notice
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a highly requested Fullscreen Video Playback feature to the Extra Metadata Loader.
Currently, the WPF
MediaElementis constrained by the parent grid (such as the Harmony theme's game details panel). This enhancement allows users to seamlessly pop the video out into a borderless, topmost, maximized window for a proper viewing experience.Implementation Details
MouseDoubleClickevent on the video surface as a secondary trigger.TimeSpanposition, volume, and mute state, and passes them to a dynamically generated maximized WPFWindowcontaining a newMediaElement.Testing
Compiled and tested successfully locally against standard 1080p H.264 MP4 files. The audio sink states cleanly translate back to the embedded view without getting de-synced.