Skip to content

Clean up main.tsx, move E2E and sentry to modules, fix error boundary#129

Open
Cas Linden (CasLinden) wants to merge 8 commits into
developfrom
cas/untangle-main-ts-entrypoint
Open

Clean up main.tsx, move E2E and sentry to modules, fix error boundary#129
Cas Linden (CasLinden) wants to merge 8 commits into
developfrom
cas/untangle-main-ts-entrypoint

Conversation

@CasLinden
Copy link
Copy Markdown
Contributor

@CasLinden Cas Linden (CasLinden) commented May 11, 2026

Summary

  • Sentry and E2E code moved to modules
  • E2E setup is conditional, and impact on sentry initiation minimal
  • Env var is made clearer
  • The fallback error component now has a recovery path

Test Plan

Farhan (@fkb032) please double check if I broke anything in the tests.
This PR is not so much about the tests as it is about their code impact.

I wasn't able to test on MacInCloud, and that thing is pretty much busy running peekaboo 24/7 on our PR branches, but te PR passed these local checks before pushing:

  • peekaboo-workflow-contract-self-test.mjs passes — the refactor's structural invariants are intact
  • bun -F native test:e2e (Playwright web smoke) — 2/2 pass; the new awaited bootstrap() order renders fine
  • new apps/native/src/lib/sentry/sanitize.test.ts — 14/14 pass; covers the extracted redaction pipeline (now a shared module consumed by both Sentry beforeSend and the E2E DOM snapshot path)
  • Sentry init + capture hot path verified

Docs

  • No docs update needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 11, 2026

Warnings
⚠️ Please assign this PR to someone (usually yourself).
⚠️ ❗ Big PR (1554 lines changed). Consider splitting it into smaller, focused changes.
Messages
📖

🤖 This PR touches CI / infra — reviewers please pay extra attention:

  • .github/workflows/peekaboo-e2e.yml

📋 PR Overview

Lines changed 1554 (+930 / -624)
Files 10 added, 7 modified, 1 deleted
Draft / WIP no
Has Test Plan yes
New UI components yes (1)
New Storybook stories yes (1)
New Rust modules no
New TS source files yes (7)
New tests yes (1)
package.json touched no
Cargo.toml touched no
Infra / CI touched yes

Generated by 🚫 dangerJS against da2604d

@CasLinden
Copy link
Copy Markdown
Contributor Author

drafting, need to check something

@CasLinden Cas Linden (CasLinden) marked this pull request as draft May 11, 2026 10:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 12, 2026

nixmac Peekaboo E2E: ❌ FAIL

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks much nicer 👏

I tried to run the the commands in the "test" plan, I am having trouble with this one:

bun -F native test:e2e
native test:e2e $ playwright test
│ [33 lines elided]
│     ║     npx playwright install                                 ║
│     ║                                                            ║
│     ║ <3 Playwright Team                                         ║
│     ╚════════════════════════════════════════════════════════════╝
│
│     Error Context: test-results/app-page-has-expected-title-chromium/error-context.md
│
│   2 failed
│     [chromium] › e2e/app.spec.ts:10:1 › app shell mounts ───────────────────────────────────────────
│     [chromium] › e2e/app.spec.ts:18:1 › page has expected title ────────────────────────────────────
└─ Exited with code 1

On my end it looks fine but probably Farhan (@fkb032) wants to check if e2e tests still run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants