Clean up main.tsx, move E2E and sentry to modules, fix error boundary#129
Open
Cas Linden (CasLinden) wants to merge 8 commits into
Open
Clean up main.tsx, move E2E and sentry to modules, fix error boundary#129Cas Linden (CasLinden) wants to merge 8 commits into
Cas Linden (CasLinden) wants to merge 8 commits into
Conversation
…decouple e2e initiation from sentry init in production
Contributor
📋 PR Overview
|
Contributor
Author
|
drafting, need to check something |
Contributor
nixmac Peekaboo E2E: ❌ FAIL
|
Juanpe Bolívar (arximboldi)
approved these changes
May 14, 2026
Contributor
Juanpe Bolívar (arximboldi)
left a comment
There was a problem hiding this comment.
The code looks much nicer 👏
I tried to run the the commands in the "test" plan, I am having trouble with this one:
bun -F native test:e2e
native test:e2e $ playwright test
│ [33 lines elided]
│ ║ npx playwright install ║
│ ║ ║
│ ║ <3 Playwright Team ║
│ ╚════════════════════════════════════════════════════════════╝
│
│ Error Context: test-results/app-page-has-expected-title-chromium/error-context.md
│
│ 2 failed
│ [chromium] › e2e/app.spec.ts:10:1 › app shell mounts ───────────────────────────────────────────
│ [chromium] › e2e/app.spec.ts:18:1 › page has expected title ────────────────────────────────────
└─ Exited with code 1
On my end it looks fine but probably Farhan (@fkb032) wants to check if e2e tests still run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test Plan
Farhan (@fkb032) please double check if I broke anything in the tests.
This PR is not so much about the tests as it is about their code impact.
I wasn't able to test on MacInCloud, and that thing is pretty much busy running peekaboo 24/7 on our PR branches, but te PR passed these local checks before pushing:
peekaboo-workflow-contract-self-test.mjspasses — the refactor's structural invariants are intactbun -F native test:e2e(Playwright web smoke) — 2/2 pass; the new awaitedbootstrap()order renders fineapps/native/src/lib/sentry/sanitize.test.ts— 14/14 pass; covers the extracted redaction pipeline (now a shared module consumed by both SentrybeforeSendand the E2E DOM snapshot path)Docs