ci(e2e): make E2E workflows manual-only#149
Conversation
📋 PR Overview
🔬 Coverage
|
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 158ec028c8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| - 'tools/computer-use-e2e/**' | ||
| - '.github/workflows/build.yaml' | ||
| - '.github/workflows/peekaboo-e2e.yml' | ||
| workflow_dispatch: |
There was a problem hiding this comment.
Update the Peekaboo contract test before removing PR triggers
With the Peekaboo workflow now manual-only, every workflow_dispatch run still reaches Validate Peekaboo workflow contract, which executes node tools/computer-use-e2e/peekaboo-workflow-contract-self-test.mjs; that test still asserts the removed paths trigger includes package/Cargo/Nix/devenv files, so manual runs fail before doing any E2E work. I confirmed this by running the self-test locally, which fails on the missing trigger-path assertion.
Useful? React with 👍 / 👎.
Juanpe Bolívar (arximboldi)
left a comment
There was a problem hiding this comment.
Nice! 👏
With this, the only Red checkmark is the ci/hercules/onPush/default thing. cooper (@czxtm) can we disable one so that we can disable merging of "red" PR's?
Summary
pull_requesttriggers instead of commenting them outworkflow_dispatchavailable for explicit debugging runsClaude review ran before implementation. No blockers. Callouts from review:
e2e:*label-triggered scenarios are intentionally paused too; in-flight E2E runs may still finish/comment unless cancelled; manual runs currently provide workflow summaries/artifacts rather than PR-hosted report comments.Test Plan
ruby -e 'require "yaml"; ARGV.each { |path| YAML.load_file(path); puts "ok #{path}" }' .github/workflows/e2e.yml .github/workflows/peekaboo-e2e.yml .github/workflows/computer-use-e2e.ymlactionlint -shellcheck= .github/workflows/e2e.yml .github/workflows/peekaboo-e2e.yml .github/workflows/computer-use-e2e.ymlrg -n "^ pull_request:|^ workflow_dispatch:|pull_request\.branches|types: \[opened|labeled\]" .github/workflows/e2e.yml .github/workflows/peekaboo-e2e.yml .github/workflows/computer-use-e2e.ymlDocs