Skip to content

ci(e2e): make E2E workflows manual-only#149

Open
Farhan (fkb032) wants to merge 2 commits into
developfrom
fkb/e2e-quiet-mode
Open

ci(e2e): make E2E workflows manual-only#149
Farhan (fkb032) wants to merge 2 commits into
developfrom
fkb/e2e-quiet-mode

Conversation

@fkb032
Copy link
Copy Markdown
Contributor

Summary

  • makes the legacy E2E, Peekaboo E2E, and Computer Use E2E workflows manual-only while Tart-based E2E work is in progress
  • deletes the automatic pull_request triggers instead of commenting them out
  • keeps workflow_dispatch available for explicit debugging runs
  • updates the legacy E2E header so it no longer advertises path/label-triggered execution

Claude review ran before implementation. No blockers. Callouts from review: e2e:* label-triggered scenarios are intentionally paused too; in-flight E2E runs may still finish/comment unless cancelled; manual runs currently provide workflow summaries/artifacts rather than PR-hosted report comments.

Test Plan

  • ruby -e 'require "yaml"; ARGV.each { |path| YAML.load_file(path); puts "ok #{path}" }' .github/workflows/e2e.yml .github/workflows/peekaboo-e2e.yml .github/workflows/computer-use-e2e.yml
  • actionlint -shellcheck= .github/workflows/e2e.yml .github/workflows/peekaboo-e2e.yml .github/workflows/computer-use-e2e.yml
  • rg -n "^ pull_request:|^ workflow_dispatch:|pull_request\.branches|types: \[opened|labeled\]" .github/workflows/e2e.yml .github/workflows/peekaboo-e2e.yml .github/workflows/computer-use-e2e.yml

Docs

  • No docs update needed

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented May 13, 2026

Warnings
⚠️ Please assign this PR to someone (usually yourself).
Messages
📖

🤖 This PR touches CI / infra — reviewers please pay extra attention:

  • .github/workflows/computer-use-e2e.yml
  • .github/workflows/e2e.yml
  • .github/workflows/peekaboo-e2e.yml

📋 PR Overview

Lines changed 78 (+10 / -68)
Files 0 added, 3 modified, 0 deleted
Draft / WIP no
Has Test Plan yes
New UI components no
New Storybook stories no
New Rust modules no
New TS source files no
New tests no
package.json touched no
Cargo.toml touched no
Infra / CI touched yes

🔬 Coverage

Report Lines Statements Functions Branches
apps/native/coverage/coverage-summary.json 17.3% 17.3% 27.8% 52.9%

Generated by 🚫 dangerJS against 7c8d1a6

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 158ec028c8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "Codex (@codex) review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".

- 'tools/computer-use-e2e/**'
- '.github/workflows/build.yaml'
- '.github/workflows/peekaboo-e2e.yml'
workflow_dispatch:
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Update the Peekaboo contract test before removing PR triggers

With the Peekaboo workflow now manual-only, every workflow_dispatch run still reaches Validate Peekaboo workflow contract, which executes node tools/computer-use-e2e/peekaboo-workflow-contract-self-test.mjs; that test still asserts the removed paths trigger includes package/Cargo/Nix/devenv files, so manual runs fail before doing any E2E work. I confirmed this by running the self-test locally, which fails on the missing trigger-path assertion.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! 👏

With this, the only Red checkmark is the ci/hercules/onPush/default thing. cooper (@czxtm) can we disable one so that we can disable merging of "red" PR's?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants