bugfix: properly initialize collection filters defaults #20113
Merged
+9
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make conf defaults for collection filters match how they are reset via _filtering_rest(_PRESET_FILTERS). This fixes a disappearing images bug which manifests when darktable is invoked for the first time with image files/directories on the command line. Images disappeared in lighttable once they had been brought into darkroom view. No images were visible in lighttable if the user exited then reopened darktable. Fixes darktable-org#20106
TurboGit
added
bugfix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make conf defaults for collection filters match how they are reset via
_filtering_rest(_PRESET_FILTERS).This fixes a disappearing images bug which manifests when darktable is invoked for the first time with image files/directories on the command line. Images disappeared in lighttable once they had been brought into darkroom view. No images were visible in lighttable if the user exited then reopened darktable.
Fixes #20106