Allow the rotate and perspective module to perform a rotation with one fit line#20585
Open
lefth wants to merge 1 commit intodarktable-org:masterfrom
Open
Allow the rotate and perspective module to perform a rotation with one fit line#20585lefth wants to merge 1 commit intodarktable-org:masterfrom
lefth wants to merge 1 commit intodarktable-org:masterfrom
Conversation
…e fit line The algorithm already supported this operation, but the check for minimum lines was too strict. This fixes darktable-org#20584.
Member
|
@lefth : Back to this after a quite long work/review on the new AI features. I'm not convinced by this proposal. Having failed algorithm except the rotation fill really awkward and sounds like a bad UX to me. The rotation is supported by right-click on the image and I think we should stay with that. |
TurboGit
added
controversial
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The algorithm already supported this operation, but the check for minimum lines was too strict.
With this change, all the operations still seem to work correctly:
This fixes #20584.