[AI] Skip model card for not-downloaded rows#20966
[AI] Skip model card for not-downloaded rows#20966andriiryzhkov wants to merge 1 commit intodarktable-org:masterfrom
Conversation
| model->id, | ||
| COL_INFO, | ||
| "\xe2\x84\xb9", // ℹ (U+2139) | ||
| is_downloaded ? "\xe2\x84\xb9" : "", |
There was a problem hiding this comment.
Would using U+1F6C8 working on Windows too? If so maybe a better icon that a simple i?
🛈
What do you think?
There was a problem hiding this comment.
Would using U+1F6C8 working on Windows too?
I tested U+1F6C8 ("circled information source", "\xf0\x9f\x9b\x88") on Windows 11 and latest Ubuntu (without any additional font installations). It works. I also tried another symbol, U+24D8, it works too.
If so maybe a better icon that a simple i?
It's actually not just a simple "i" character, but a Unicode character "information source" (U+2139). Maybe on macOS it looks like a special information sign, but unfortunately on Windows and Linux it looks like a simple letter "i" and it doesn't make the user think that we have a special sign for getting information.
So I would recommend replacing this with one of two other options:
- 🛈 --- U+1F6C8 ("Circled Information Source")
- ⓘ --- U+24D8 ("Circled Latin Small Letter I")
There was a problem hiding this comment.
I tried couple variants when developing this initially and current one just seemed the most safe one.
I will test proposed options and share my thoughts on this.
3 participants
The model card opens from a per-model on-disk config that doesn't exist until the model has been downloaded. Clicking the "ℹ" icon on a not-downloaded row used to attempt to open an empty card. This fix gates the entire info-column UI – glyph, hand cursor, tooltip, click action – on the model's download status.