Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces an option to override default LLMQ parameters by adding an optional llmqParamsOverride argument across various classes. Key changes include:
- Adding llmqParamsOverride to payload parsing in CommitmentTxPayload.
- Propagating llmqParamsOverride in SimplifiedMNListDiff and SimplifiedMNList helper functions.
- Modifying QuorumEntry and constants to support quorum parameter overrides.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| lib/transaction/payload/commitmenttxpayload.js | Updated fromBuffer to accept and pass llmqParamsOverride to QuorumEntry.getParams. |
| lib/deterministicmnlist/SimplifiedMNListDiff.js | Added llmqParamsOverride parameter to constructors and parsing functions (fromBuffer, fromObject, fromHexString, fromJSON). |
| lib/deterministicmnlist/SimplifiedMNList.js | Propagated llmqParamsOverride through the constructor and related methods. |
| lib/deterministicmnlist/QuorumEntry.js | Revised constructor and helper methods to handle llmqParamsOverride and merged parameters using _.merge. |
| lib/constants/index.js | Defined LLMQ_TYPE_PARAMS to centralize default quorum parameters. |
Comments suppressed due to low confidence (1)
lib/deterministicmnlist/QuorumEntry.js:75
- The check 'if (arg instanceof QuorumEntry)' is repeated in the constructor. Removing the duplicate check can simplify the logic and improve clarity.
if (arg instanceof QuorumEntry) {
QuantumExplorer
previously approved these changes
Apr 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue being fixed or feature implemented
We use custom quorum params for the local network in order to use only one masternode instead of 3
What was done?
How Has This Been Tested?
As a part of test suite
Breaking Changes
None
Checklist: