Skip to content

docs: trim batch transformer bump comment #3628

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thepastaclaw wants to merge 1 commit into from
Closed

docs: trim batch transformer bump comment #3628

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions ...i/src/execution/validation/state_transition/state_transitions/batch/transformer/v0/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -753,12 +753,9 @@ impl BatchTransitionInternalTransformerV0 for BatchTransition {
Self::find_replaced_document_v0(transition, replaced_documents);

if !validation_result.is_valid_with_data() {
// Replace's missing-target-document path is the one
// failure site that already emitted a bump action on
// PROTOCOL_VERSION_11 (pre-PR), so it must continue to
// do so regardless of `failed_per_transition_action`.
// Routing it through the helper would drop the bump on
// v0 and diverge v11 chain replay.
// Keep this bump emission inline (not via Self::failed_per_transition_action):
// it's the one legacy v0 bump site, and routing it through the helper would
// drop the bump on PROTOCOL_VERSION_11 and diverge v11 chain replay (#2867).
let bump_action =
BumpIdentityDataContractNonceAction::from_borrowed_document_base_transition(
document_replace_transition.base(),
Expand Down
Loading