Enhanced Deal Tracker Integration (#572)#578
Open
anjor wants to merge 1 commit intodata-preservation-programs:developfrom
Open
Enhanced Deal Tracker Integration (#572)#578anjor wants to merge 1 commit intodata-preservation-programs:developfrom
anjor wants to merge 1 commit intodata-preservation-programs:developfrom
Conversation
…ion-programs#572 Enhanced DealTracker and StateTracker integration with comprehensive on-chain event handling: **StateTracker Enhancements:** - Added enhanced metadata tracking with error categorization - Improved error handling with specific error categories (network, provider, client, chain, etc.) - Extended metadata fields for comprehensive deal tracking - Added helper functions for error categorization and metadata creation - Implemented TrackStateChangeWithError for better error tracking **DealTracker Enhancements:** - Enhanced state change tracking with detailed metadata for all deal transitions - Added special handling for critical deal events (slashed, expired, activated) - Improved logging for deal state transitions with contextual information - Enhanced expiration handling for both active deals and proposals - Better tracking of external deal discovery with comprehensive metadata **Special Handling for Critical Events:** - Deal slashing: Enhanced logging and metadata with slashing epoch details - Deal expiration: Detailed tracking of natural expiration with epoch information - Proposal expiration: Comprehensive handling of unactivated proposals - Deal activation: Proper tracking with sector start epoch information **Comprehensive Testing:** - Added 296+ lines of new unit and integration tests - Enhanced test coverage for error categorization and metadata creation - Integration tests for slashed deal detection and handling - Tests for external deal discovery with enhanced metadata - Comprehensive expiration testing for deals and proposals **Key Features:** - Error categorization system for better analytics and debugging - Enhanced metadata collection including piece size, verified status, pricing - Improved recovery mechanisms for missing state changes - Better performance monitoring and error tracking - Comprehensive logging for all deal lifecycle events All tests pass and the implementation maintains backward compatibility while significantly enhancing the deal tracking capabilities.
Contributor
|
@anjor, this branch has merge conflicts with develop. Could you resolve them before we proceed with final review? |
Collaborator
|
this looks reasonably sane, I will come back to rebase and review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Test Plan
Resolves #572