Skip to content
Draft
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
54 changes: 54 additions & 0 deletions libs/jobstest/job_test.go
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
package jobstest

import (
"encoding/json"
"testing"

"github.com/databricks/databricks-sdk-go/service/jobs"
"github.com/stretchr/testify/require"
)

type TestStruct struct {
OnFailure []string `json:"on_failure"`
}

type TestStructOmitEmpty struct {
OnFailure []string `json:"on_failure,omitempty"`
}

func TestStringSlice(t *testing.T) {
x := &jobs.JobEmailNotifications{
OnFailure: []string{},
ForceSendFields: []string{"OnFailure"},
}

xs := jsonDump(t, x)

// expecting this:
// require.Equal(t, `{"on_failure":[]}`, xs)

// but get this:
require.Equal(t, `{}`, xs)

// Compare with non-omitempty regular struct
require.Equal(t, `{"on_failure":[]}`, jsonDump(t, TestStruct{OnFailure: []string{}}))

// Compare with omitempty regular struct
require.Equal(t, `{}`, jsonDump(t, TestStructOmitEmpty{OnFailure: []string{}}))

Check failure on line 38 in libs/jobstest/job_test.go

View workflow job for this annotation

GitHub Actions / lint

File is not properly formatted (gofumpt)

Check failure on line 38 in libs/jobstest/job_test.go

View workflow job for this annotation

GitHub Actions / lint

File is not properly formatted (gofumpt)
}

func TestBool(t *testing.T) {
x := jobs.JobNotificationSettings{
NoAlertForCanceledRuns: false,
ForceSendFields: []string{"NoAlertForCanceledRuns"},
}

require.Equal(t, `{"no_alert_for_canceled_runs":false}`, jsonDump(t, x))
}

func jsonDump(t *testing.T, x any) string {
xb, err := json.Marshal(x)
require.NoError(t, err)
return string(xb)
}
Loading