Skip to content

Strip META-INF/maven/** from uber and thin JARs #1408

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
sreekanth-db wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Strip META-INF/maven/** from uber and thin JARs #1408

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ffc2a30
Strip META-INF/maven/** from uber JAR
sreekanth-db Apr 14, 2026
a550873
Strip META-INF/maven/** from thin JAR as well
sreekanth-db Apr 15, 2026
54f8784
Update changelog to mention both uber and thin JARs
sreekanth-db Apr 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions NEXT_CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@
### Updated

### Fixed
- Stripped `META-INF/maven/**` (`pom.properties`, `pom.xml`) from the uber and thin JARs.
- Fixed `IntervalConverter` crash (`IllegalArgumentException: Invalid interval metadata`) when INTERVAL columns are returned via CloudFetch. Arrow metadata from CloudFetch uses underscored format (`INTERVAL_YEAR_MONTH`, `INTERVAL_DAY_TIME`) which the driver's regex did not accept.
- Fixed primitive types within complex types (ARRAY, MAP, STRUCT) not being correctly parsed when Arrow serialization uses alternate formats: TIMESTAMP/TIMESTAMP_NTZ as epoch microseconds or component arrays, and BINARY as base64-encoded strings.
- Fixed `PARSE_SYNTAX_ERROR` for column names containing special characters (e.g., dots) when `EnableBatchedInserts` is enabled, by re-quoting column names with backticks in reconstructed multi-row INSERT statements.
Expand Down
1 change: 1 addition & 0 deletions assembly-thin/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@
<exclude>META-INF/DEPENDENCIES</exclude>
<exclude>META-INF/LICENSE.txt</exclude>
<exclude>META-INF/versions/**</exclude>
<exclude>META-INF/maven/**</exclude>
</excludes>
Copy link
Copy Markdown
Collaborator

@vikrantpuppala vikrantpuppala Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[F1] Thin JAR: useDependencyReducedPomInJar interaction with new exclude (Severity: Medium)

The thin JAR sets useDependencyReducedPomInJar=true at assembly-thin/pom.xml:116-118, which embeds a reduced POM inside the JAR at META-INF/maven/<groupId>/<artifactId>/pom.xml. The new META-INF/maven/** exclude will strip that embedded reduced POM as well.

If any consumer of the thin JAR reads the embedded reduced POM at runtime (rather than fetching the sibling .pom from Maven Central), this silently removes it.

Suggested fix: Either

  1. Confirm the embedded reduced POM is intentionally stripped (likely fine — most consumers use the Maven Central POM), and call this out in the PR description / changelog, or
  2. Narrow the exclude to META-INF/maven/**/pom.properties so the reduced pom.xml remains embedded.

Posted by Code Review Squad.

Copy link
Copy Markdown
Collaborator Author

@sreekanth-db sreekanth-db Apr 17, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, this change is intentional and mentioned in the change log

</filter>
</filters>
Expand Down
1 change: 1 addition & 0 deletions assembly-uber/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -204,6 +204,7 @@
<exclude>META-INF/DEPENDENCIES</exclude>
<exclude>META-INF/LICENSE.txt</exclude>
<exclude>META-INF/versions/**</exclude>
<exclude>META-INF/maven/**</exclude>
</excludes>
</filter>
<filter>
Expand Down
Loading