Fail when explicit scopes used with databricks-cli auth#1427
Merged
tejaskochar-db merged 6 commits intomainfrom Jan 29, 2026
Merged
Fail when explicit scopes used with databricks-cli auth#1427tejaskochar-db merged 6 commits intomainfrom
tejaskochar-db merged 6 commits intomainfrom
Conversation
…atabricks-cli auth
c5370de to
69bdac8
Compare
renaudhartert-db
approved these changes
Jan 29, 2026
Contributor
renaudhartert-db
left a comment
There was a problem hiding this comment.
I think we could simplify that by returning a const errors in validateScopes. This will allow you to directly test the gotErr against the wantErr using errors.Is.
|
If integration tests don't run automatically, an authorized user can run them manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Adds validation to ensure users don't pass explicit scopes when using
databricks-cliauth, by returning an error.Scopes read from the config file are allowed as the auth login command writes them there.
Such validation will be added to the Python and Java SDK's databricks-cli auth as well.
Why
The token store used in databricks-cli currently keys tokens by host only, so user provided scopes would be silently ignored. This validation prevents that from happening by informing users with an error.
How is this tested?
Unit tests for the validation logic
NO_CHANGELOG=true