chore(deps): Update npm packages to remediate security vulnerabilities#368
chore(deps): Update npm packages to remediate security vulnerabilities#368shukrikhalid wants to merge 3 commits intodatabricks:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates npm dependencies (and the lockfile) to address reported security vulnerabilities, with minor test adjustments to accommodate upstream type/API changes (notably openid-client).
Changes:
- Bumped multiple runtime/dev dependency versions (e.g.,
openid-client,proxy-agent,thrift, lint/test tooling). - Updated OAuth unit tests to match updated
openid-clienttypings/exports. - Added an npm
overridesentry intended to force a patched transitive dependency version.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| tests/unit/connection/auth/DatabricksOAuth/OAuthManager.test.ts | Updates the Issuer test stub to include FAPI2Client for compatibility with newer openid-client types. |
| tests/unit/connection/auth/DatabricksOAuth/AuthorizationCode.test.ts | Adjusts a test double injection for createHttpServer after dependency/type updates. |
| package.json | Updates dependency versions and introduces an overrides rule for serialize-javascript. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| "lz4": "^0.6.5" | ||
| }, | ||
| "overrides": { | ||
| "serialize-javascript": "^7.0.5" |
There was a problem hiding this comment.
serialize-javascript <=7.0.4
Severity: high
Serialize JavaScript is Vulnerable to RCE via RegExp.flags and Date.prototype.toISOString() - GHSA-5c6j-r48x-rmvq
Serialize JavaScript has CPU Exhaustion Denial of Service via crafted array-like objects - GHSA-qj8w-gfj5-8c6v
fix available via npm audit fix --force
Will install mocha@7.2.0, which is a breaking change
node_modules/mocha/node_modules/serialize-javascript
mocha 8.0.0 - 12.0.0-beta-2
Depends on vulnerable versions of serialize-javascript
node_modules/mocha
2 high severity vulnerabilities
Summary
Changes
proxy-agent/get-urichain).Verification
Risk / Impact
Checklist