ci(min-deps): promote min-deps to first-class CI alongside latest-deps#1480
Open
sd-db wants to merge 2 commits into
Open
ci(min-deps): promote min-deps to first-class CI alongside latest-deps#1480sd-db wants to merge 2 commits into
sd-db wants to merge 2 commits into
Conversation
- setup-python-deps + warmDepsCache: cache key hash includes requirements.lowest-direct.txt; warm job creates min-deps + verify-min-deps envs and downloads the lowest-direct closure into the wheelhouse so fork PRs can run min-deps tests fully offline from cache. - main-min-deps.yml (renamed from min-deps-test-fast.yml): mirrors main.yml shape — cache-restore + JFrog fallback, concurrency with cancel-in-progress, paths-ignore for *.md. Fork-skip guards removed; cache makes forks work. - integration-min-deps.yml (renamed from min-deps-test-slow.yml): adds workflow_dispatch with pr_numbers / git_ref inputs, full target parser, and a report-status job that posts a result comment back to the PR — mirroring integration.yml for the slash-command path. - integration-trigger.yml: parses the first arg after /integration-test. /integration-test min-deps routes to integration-min-deps.yml; anything else falls through to integration.yml (free-form trailing context).
Collaborator
Author
|
/integration-test min-deps |
Collaborator
Author
|
/integration-test |
|
Integration tests dispatched for PR #1480 by @sd-db. Track progress in the Actions tab. |
1 similar comment
|
Integration tests dispatched for PR #1480 by @sd-db. Track progress in the Actions tab. |
|
Integration results for PR #1480 — UC cluster ❌ cancelled · SQL warehouse ❌ cancelled · All-purpose cluster ❌ cancelled · Shard coverage ❌ cancelled |
Coverage report
This PR does not seem to contain any modification to coverable code. |
|
Integration results for PR #1480 — UC cluster ❌ failure · SQL warehouse ❌ failure · All-purpose cluster ✅ success · Shard coverage ✅ success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Today, min-deps tests fire post-merge (always) and on internal PRs (best-effort). Fork PRs are skipped because the protected runner needs a JFrog OIDC token only the
databricks/dbt-databrickssubject can mint. This PR makes min-deps a first-class CI citizen alongside latest-deps so lower-bound regressions surface pre-merge on every PR — including forks.warmDepsCache.ymlnow createsmin-deps+verify-min-depsenvs and downloads the lowest-direct closure into the shared wheelhouse. The cache key includesrequirements.lowest-direct.txt. uv stores wheels content-addressed by hash, so wheels identical across resolutions are stored once.main-min-deps.yml(renamed frommin-deps-test-fast.yml): mirrorsmain.yml—setup-python-depscache restore + JFrog fallback, concurrency withcancel-in-progress,paths-ignorefor*.md. Fork-skip guards removed; cache makes fork PRs work offline.integration-min-deps.yml(renamed frommin-deps-test-slow.yml): addsworkflow_dispatchwithpr_numbers/git_refinputs, full target parser, and areport-statusjob posting a result comment back to the PR — same shape asintegration.yml. Schedule stays nightly at 19:30 UTC.integration-trigger.yml: parses the first arg after/integration-test.min-deps→integration-min-deps.yml; anything else →integration.yml(free-form trailing context preserved).Test plan
warmDepsCache.yml(gh workflow run warmDepsCache.yml --ref sd-db/feat/min-deps-first-class-ci). Confirm logs showhatch env create min-deps+hatch env create verify-min-deps, secondpip download --no-deps --require-hashes -r requirements.lowest-direct.txtstep, and cache key derived from the 3-file hash.main.yml+main-min-deps.yml. In each job, confirmSetup Python Dependenciesreportscache-hit: trueandSetup JFrog PyPI Proxy (fallback)shows as skipped. Unit + build jobs pass./integration-test min-depsroutes correctly. Comment/integration-test min-depson this PR. Verifyintegration-trigger.ymldispatchesintegration-min-deps.yml(notintegration.yml); reply comment names "Min-deps integration tests";report-statusposts back with min-deps results./integration-teststill routes to latest-deps. Comment/integration-teston this PR. Verifyintegration.ymlis dispatched (regression check on the trigger parsing).integration-min-deps.yml'spreparejob short-circuits on a re-run against the same main SHA (manually dispatch twice againstmain; second run emits empty targets).