chore: Add more static optimizer#628
Merged
stephenamar-db merged 2 commits intodatabricks:masterfrom Mar 6, 2026
Merged
Conversation
He-Pin
force-pushed
the
staticOptimizer
branch
8 times, most recently
from
a02576e to
4f8f074
Compare
He-Pin
commented
Mar 5, 2026
| case e => e | ||
| // Aggressive optimizations: constant folding, branch elimination, short-circuit elimination. | ||
| // These reduce AST node count at parse time, benefiting long-running Jsonnet programs. | ||
| case e => if (aggressiveOptimization) tryAggressiveOptimize(e) else e |
Contributor
Author
There was a problem hiding this comment.
only do this after a flag
Contributor
Author
|
I think this is ok now, this would be nice for a long-running JSONNet program |
Collaborator
|
resolve conflicts. |
| * constant conditions; short-circuit elimination for And/Or with constant lhs. These reduce AST | ||
| * node count, benefiting long-running Jsonnet programs. | ||
| */ | ||
| aggressiveStaticOptimization: Boolean = false |
Collaborator
There was a problem hiding this comment.
What the risk with having that by default? are you worried about correctness?
stephenamar-db
pushed a commit
that referenced
this pull request
Mar 7, 2026
Address @stephenamar-db 's comment in #628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation:
more aggressive optimization, but behind a flag, the default is false.
master:
this branch with
aggressiveStaticOptimization=true:refs: google/go-jsonnet#858