Add --max-stack / -s flag to limit stack depth#637
Merged
stephenamar-db merged 1 commit intomasterfrom Mar 5, 2026
Merged
Conversation
stephenamar-db
force-pushed
the
stack/erro3
branch
from
9871177 to
995f81c
Compare
Introduces a stack frame counter in the Evaluator, incremented/decremented at function calls (Apply*, ApplyBuiltin*), object field evaluation (invoke), imports, and default parameter evaluation. When the counter exceeds maxStack, a clear sjsonnet.Error is thrown instead of a JVM StackOverflowError.
stephenamar-db
force-pushed
the
stack/erro3
branch
from
995f81c to
1a45c92
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--max-stack/-sCLI flag (default 500) to limit the evaluation stack depth, matching go-jsonnet's-s/--max-stackoption.Apply*,ApplyBuiltin*), object field evaluation (invoke), imports, and default parameter evaluation.maxStack, a clearsjsonnet.Error: Max stack frames exceeded.is thrown instead of a raw JVMStackOverflowError.Test plan
error.recursive_function_nonterm,error.recursive_import,error.recursive_object_non_term, anderror.function_infinite_default--max-stackand-sshort form