WHO Tuberculosis PT Data Import#2004
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new data import for WHO Tuberculosis preventive treatment statistics, including a download script, metadata, and mapping files. The code review identifies several critical issues, most notably the inclusion of unresolved git conflict markers in multiple files. Actionable feedback also includes correcting inconsistencies in the populationType attribute, removing a duplicate mapping file, and improving the download script's reliability by adding timeouts to HTTP requests. Furthermore, the manifest file needs to be updated to adhere to repository standards regarding the quoting of file paths in scripts.
|
@pravnkumar-cloudsufi Have you ran the LLM review on the PR? |
|
Hello @pravnkumar-cloudsufi, I have completed the review of your pull request for the WHO Tuberculosis Preventive Treatment data import. The implementation looks solid and follows the repository's established patterns for data imports. Review Summary
Everything appears to be in order. Great work on this contribution! |
saanikaaa
left a comment
There was a problem hiding this comment.
we can remove StatVar Mcf and schema MCF from test data as it is one time activity and we are adding all the schema as part of import
Hi @saanikaaa, I have removed the StatVar Mcf and schema MCF from the test data. Please review. |
Please find the PR Checklist: https://docs.google.com/spreadsheets/d/1fmOgPpbf3zao7ouz8elEKxTtWmOxj0OrOEkUQzk92yI/edit?resourcekey=0--OoqVHRDwzvT84pVUGSFMA&gid=1825756362#gid=1825756362