Skip to content

WHO Tuberculosis PT Data Import#2004

Open
pravnkumar-cloudsufi wants to merge 5 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:TuberculosisPT
Open

WHO Tuberculosis PT Data Import#2004
pravnkumar-cloudsufi wants to merge 5 commits into
datacommonsorg:masterfrom
pravnkumar-cloudsufi:TuberculosisPT

Conversation

@pravnkumar-cloudsufi
Copy link
Copy Markdown

@pravnkumar-cloudsufi pravnkumar-cloudsufi commented May 13, 2026

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new data import for WHO Tuberculosis preventive treatment statistics, including a download script, metadata, and mapping files. The code review identifies several critical issues, most notably the inclusion of unresolved git conflict markers in multiple files. Actionable feedback also includes correcting inconsistencies in the populationType attribute, removing a duplicate mapping file, and improving the download script's reliability by adding timeouts to HTTP requests. Furthermore, the manifest file needs to be updated to adhere to repository standards regarding the quoting of file paths in scripts.

Comment thread statvar_imports/tuberculosis_preventive_treatment/README.md Outdated
Comment thread statvar_imports/tuberculosis_preventive_treatment/README.md Outdated
Comment thread statvar_imports/tuberculosis_preventive_treatment/README.md Outdated
Comment thread statvar_imports/tuberculosis_preventive_treatment/manifest.json Outdated
Comment thread statvar_imports/tuberculosis_preventive_treatment/tb_data_download_who.py Outdated
Comment thread statvar_imports/tuberculosis_preventive_treatment/tb_data_download_who.py Outdated
@pulkeet-wq
Copy link
Copy Markdown
Contributor

@pravnkumar-cloudsufi Have you ran the LLM review on the PR?

@pravnkumar-cloudsufi
Copy link
Copy Markdown
Author

@gemini-code-assist

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Hello @pravnkumar-cloudsufi, I have completed the review of your pull request for the WHO Tuberculosis Preventive Treatment data import. The implementation looks solid and follows the repository's established patterns for data imports.

Review Summary

  • Code Structure: The Python download script (tb_data_download_who.py) is well-structured, handles API interactions and data merging correctly, and includes appropriate logging.
  • Configuration: The manifest.json, tuberculosis_PreventiveTreatment_metadata.csv, and tuberculosis_PreventiveTreatment_pvmap.csv files are correctly configured for the data pipeline.
  • Documentation: The README.md provides clear instructions for both downloading and processing the data.
  • Testing: The inclusion of test data and expected output files (testdata/) is excellent and ensures the pipeline's reliability.

Everything appears to be in order. Great work on this contribution!

Copy link
Copy Markdown
Contributor

@saanikaaa saanikaaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we can remove StatVar Mcf and schema MCF from test data as it is one time activity and we are adding all the schema as part of import

@pravnkumar-cloudsufi
Copy link
Copy Markdown
Author

we can remove StatVar Mcf and schema MCF from test data as it is one time activity and we are adding all the schema as part of import

Hi @saanikaaa, I have removed the StatVar Mcf and schema MCF from the test data. Please review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants