Add config to disable skip status#2011
Merged
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces a new configuration setting, enable_skip_status, to allow skipping data ingestion when no changes are detected. While the global configuration and manifest overrides were added, the implementation in import_executor.py currently ignores the per-import overrides. Feedback suggests updating the logic to check the import_spec for configuration overrides before falling back to the global default.
rohitkumarbhagat
approved these changes
May 14, 2026
vish-cs
force-pushed
the
skip
branch
2 times, most recently
from
623f46c to
73625b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is required for the integration test. We repeatedly run the same import for ingestion during the test. Recently, we added a SKIP state where the import is skipped if there is no data change which happens for the integration test. This change is to force the ingestion even if there is no data change so we can verify the E2E flow.