Add NL sidebar for website autopush on dc-mixer-default to enable v2/resolve for SV search through NL server#6210
Conversation
…resolve for SV search through NL server
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a configuration change to the skaffold deployment settings for the autopush environment. The primary purpose is to enable the NL (Natural Language) sidebar functionality by activating the embeddings sidecar for the default service group, facilitating v2/resolve capabilities for SV search. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
| mixer.hostProject: "datcom-website-autopush" | ||
| mixer.serviceName: "website-esp.endpoints.datcom-website-autopush.cloud.goog" | ||
| serviceGroups.recon.enableEmbeddingsSidecar: "false" | ||
| serviceGroups.default.enableEmbeddingsSidecar: "true" |
There was a problem hiding this comment.
In mixer, we set enableEmbeddingsSidecar to true for recon, which is why the line above sets it to false for website's recon.
Is it intentional to put this in defualt? Why have it in different mixer service groups across website and mixer?
There was a problem hiding this comment.
For website, the recon workload isn't used:
website/deploy/helm_charts/envs/autopush.yaml
Lines 95 to 96 in 3f077cb
resolve traffic is routed to the default workload. Which is why for website-autopush we want the embeddings server in default and not recon
| mixer.hostProject: "datcom-website-autopush" | ||
| mixer.serviceName: "website-esp.endpoints.datcom-website-autopush.cloud.goog" | ||
| serviceGroups.recon.enableEmbeddingsSidecar: "false" | ||
| serviceGroups.default.enableEmbeddingsSidecar: "true" |
There was a problem hiding this comment.
Xiao, separate note is that this provides an added risk at deployment. So just make sure to monitor when this gets released to autopush, staging and prod and just double check this looks healthy.
Might want a note to secondary oncaller when he does the release.
clincoln8
left a comment
There was a problem hiding this comment.
Thanks Xiao! Make sure to notify oncall thread about change to deployment for autopush
This is the first PR to try enable NL sidebar for dc-mixer-default in website
It will work on autopush, later PR will be done for staging and prod once this is fine