Skip to content

Add NL sidebar for website autopush on dc-mixer-default to enable v2/resolve for SV search through NL server#6210

Open
shixiao-coder wants to merge 7 commits into
datacommonsorg:masterfrom
shixiao-coder:add-embedding-sidebar-to-mixer-in-autopush
Open

Add NL sidebar for website autopush on dc-mixer-default to enable v2/resolve for SV search through NL server#6210
shixiao-coder wants to merge 7 commits into
datacommonsorg:masterfrom
shixiao-coder:add-embedding-sidebar-to-mixer-in-autopush

Conversation

@shixiao-coder
Copy link
Copy Markdown
Contributor

This is the first PR to try enable NL sidebar for dc-mixer-default in website

It will work on autopush, later PR will be done for staging and prod once this is fine

@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a configuration change to the skaffold deployment settings for the autopush environment. The primary purpose is to enable the NL (Natural Language) sidebar functionality by activating the embeddings sidecar for the default service group, facilitating v2/resolve capabilities for SV search.

Highlights

  • Configuration Update: Enabled the embeddings sidecar for the default service group in the autopush environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the skaffold.yaml configuration to enable the embeddings sidecar for the default service group within the autopush profile. There are no review comments to address, and I have no further feedback to provide.

Comment thread skaffold.yaml
mixer.hostProject: "datcom-website-autopush"
mixer.serviceName: "website-esp.endpoints.datcom-website-autopush.cloud.goog"
serviceGroups.recon.enableEmbeddingsSidecar: "false"
serviceGroups.default.enableEmbeddingsSidecar: "true"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/datacommonsorg/mixer/blob/303a7931ac3e5f9436571fbd0c4b6432182b1de4/deploy/helm_charts/mixer/values.yaml#L441

In mixer, we set enableEmbeddingsSidecar to true for recon, which is why the line above sets it to false for website's recon.

Is it intentional to put this in defualt? Why have it in different mixer service groups across website and mixer?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For website, the recon workload isn't used:

serviceGroups:
recon: null

resolve traffic is routed to the default workload. Which is why for website-autopush we want the embeddings server in default and not recon

Comment thread skaffold.yaml
mixer.hostProject: "datcom-website-autopush"
mixer.serviceName: "website-esp.endpoints.datcom-website-autopush.cloud.goog"
serviceGroups.recon.enableEmbeddingsSidecar: "false"
serviceGroups.default.enableEmbeddingsSidecar: "true"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Xiao, separate note is that this provides an added risk at deployment. So just make sure to monitor when this gets released to autopush, staging and prod and just double check this looks healthy.
Might want a note to secondary oncaller when he does the release.

Copy link
Copy Markdown
Contributor

@clincoln8 clincoln8 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Xiao! Make sure to notify oncall thread about change to deployment for autopush

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants