Modify the code to only keep Gemini 3 related setup and remove all Gemini 2.5 setup#6226
Open
shixiao-coder wants to merge 6 commits into
Open
Conversation
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting |
gmechali
approved these changes
Apr 28, 2026
| formatted_prompt=formatted_follow_up_questions_prompt, | ||
| schema=FollowUpQuestions, | ||
| gemini_model=gemini_model, | ||
| use_thinking_config=use_thinking_config) |
Contributor
There was a problem hiding this comment.
instead of setting use_think_config and gemini_model on lines 317 and 318, can you just set them here? Avoids redundancy
| ENABLE_STAT_VAR_AUTOCOMPLETE = 'enable_stat_var_autocomplete' | ||
| ENABLE_NL_AGENT_DETECTOR = 'enable_nl_agent_detector' | ||
| NEW_RANKING_PAGE = 'new_ranking_page' | ||
| ENABLE_GEMINI_3_FLASH = 'enable_gemini_3_flash' |
Contributor
There was a problem hiding this comment.
After this PR is released to 2 prod cycles, make sure to delete the feature flag from the feature flag .json files!
2 prod cycles so that if we have to do a rollback at some point, it's still safe!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR update all calls that uses feature flag for Gemini 3 and removes all logics, constant related to Gemini 2.5