Skip to content

Automated Integration Test Goldens Update from CI#6236

Open
datacommons-robot-author wants to merge 3 commits into
masterfrom
nl-golden-update-72b047a4-5cf7-4bac-9e1a-bf854ca6812d
Open

Automated Integration Test Goldens Update from CI#6236
datacommons-robot-author wants to merge 3 commits into
masterfrom
nl-golden-update-72b047a4-5cf7-4bac-9e1a-bf854ca6812d

Conversation

@datacommons-robot-author
Copy link
Copy Markdown
Collaborator

This pull request updates the golden files automatically via Cloud Build. Please review the changes carefully. Cloud Build Log

@datacommons-robot-author datacommons-robot-author requested review from a team and beets and removed request for a team April 23, 2026 18:18
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request contains automated updates to the integration test golden files, ensuring that the test suite remains synchronized with the latest system outputs. These changes are necessary to maintain test reliability and reflect recent adjustments in data processing and visualization configurations.

Highlights

  • Golden File Updates: Updated integration test golden files to reflect the latest expected output from the detection API and chart configurations.
  • Configuration Adjustments: Modified chart configuration to update the mortality event data key from 2017 to 2002.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates integration test data, including a precision adjustment in a debug info file and a date reference change in a chart configuration. Feedback was provided to maintain the original rounding for floating-point scores to ensure test robustness and reduce noise.

0.63227,
0.63222,
0.6305,
0.63049,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This change in precision (from 0.6305 to 0.63049) increases review noise. Per the general rules, floating-point scores in test data should be rounded to a consistent, lower precision to make tests more robust against insignificant model output variations.

Suggested change
0.63049,
0.6305,
References
  1. Round floating-point scores in test data to a consistent, lower precision. This makes tests more robust against insignificant model output variations and reduces review noise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants