Remove release option#6253
Conversation
…'t require custom builds
This reverts commit 6c875ed.
This reverts commit 74eb475.
Co-authored-by: Christie Ellks <calinc@google.com>
…a function to use the same logic.
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request standardizes the development environment by removing the ability to run the 'latest' version of the Docker images. By restricting the script to only use the 'stable' release, it ensures a more predictable and consistent development experience for all users. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request removes the --release (or -r) option from the run_cdc_dev_docker.sh script, effectively deprecating the 'latest' release option and defaulting all container runs to the 'stable' release. The feedback focuses on correcting a formatting error in the help text where a closing quote was moved to a new line and improving the clarity of the example documentation to explicitly state that the 'stable' release is being used.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Removed the option to run the "latest" version of the gcr.io Docker images per Keyur's suggestion. This will only run the stable releases now.
I've tested it with the following flags:
./run_cdc_dev_docker.sh
./run_cdc_dev_docker.sh -e custom_dc/karas-examples/var_per_row/env.list
./run_cdc_dev_docker.sh --image cloudql-test
./run_cdc_dev_docker.sh --actions build_run --image cloudql-test
./run_cdc_dev_docker.sh -r latest (to verify that an error is returned)