Skip to content

Remove release option#6253

Open
kmoscoe wants to merge 109 commits into
datacommonsorg:masterfrom
kmoscoe:script
Open

Remove release option#6253
kmoscoe wants to merge 109 commits into
datacommonsorg:masterfrom
kmoscoe:script

Conversation

@kmoscoe
Copy link
Copy Markdown
Contributor

@kmoscoe kmoscoe commented Apr 30, 2026

Removed the option to run the "latest" version of the gcr.io Docker images per Keyur's suggestion. This will only run the stable releases now.

I've tested it with the following flags:

./run_cdc_dev_docker.sh
./run_cdc_dev_docker.sh -e custom_dc/karas-examples/var_per_row/env.list
./run_cdc_dev_docker.sh --image cloudql-test
./run_cdc_dev_docker.sh --actions build_run --image cloudql-test
./run_cdc_dev_docker.sh -r latest (to verify that an error is returned)

kmoscoe and others added 30 commits April 6, 2025 11:18
This reverts commit 6c875ed.
kmoscoe and others added 24 commits April 8, 2026 11:42
Co-authored-by: Christie Ellks <calinc@google.com>
@gemini-code-assist
Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request standardizes the development environment by removing the ability to run the 'latest' version of the Docker images. By restricting the script to only use the 'stable' release, it ensures a more predictable and consistent development experience for all users.

Highlights

  • Removal of 'latest' release option: The '--release' flag and its associated 'latest' option have been completely removed from the script, enforcing the use of the 'stable' image for all operations.
  • Script cleanup: The script logic has been simplified by removing conditional checks and variable assignments related to the 'latest' release, ensuring a consistent 'stable' environment.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kmoscoe kmoscoe requested review from clincoln8 and keyurva April 30, 2026 17:47
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the --release (or -r) option from the run_cdc_dev_docker.sh script, effectively deprecating the 'latest' release option and defaulting all container runs to the 'stable' release. The feedback focuses on correcting a formatting error in the help text where a closing quote was moved to a new line and improving the clarity of the example documentation to explicitly state that the 'stable' release is being used.

Comment thread run_cdc_dev_docker.sh Outdated
Comment thread run_cdc_dev_docker.sh Outdated
kmoscoe and others added 2 commits April 30, 2026 11:02
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant