refactor: Measurements wrapper#34
Merged
CasperTeirlinck merged 1 commit intofeat/metric-multi-instancefrom May 7, 2026
Merged
Conversation
CasperTeirlinck
changed the title
jvanbuel
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a
Measurementsclass to hold the collection of measurements and their mapping to metrics. Triggered by this comment.This aims to make the interface more intuitive and cleaner for metrics. Since #31 introduces a list of Measurements, the "default" case of one measurement per metric now required indexing which looks ugly. I added a get_single helper function to the Metric but the long type hint
dict[type[Metric], list[Measurement]]remained.This touches a lot of files because it changes the API for Metrics, but the main addition is here:
src/checkup/measurement.py.Also cleaned up some test files.