Skip to content

Internal/The row lenght was updated to be less than 120 chars#1274

Merged
milanmajchrak merged 1 commit intodtq-devfrom
internal/fix-checkstyle
Mar 13, 2026
Merged

Internal/The row lenght was updated to be less than 120 chars#1274
milanmajchrak merged 1 commit intodtq-devfrom
internal/fix-checkstyle

Conversation

@milanmajchrak
Copy link
Collaborator

Problem description

Just fixed the checkstyle issue.

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

Copilot AI review requested due to automatic review settings March 13, 2026 14:24
@milanmajchrak milanmajchrak merged commit db67645 into dtq-dev Mar 13, 2026
8 checks passed
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates DSpaceApiExceptionControllerAdvice to resolve a Checkstyle max line-length violation by wrapping the notFoundLog logger initialization, keeping the REST exception handling behavior unchanged.

Changes:

  • Wraps the notFoundLog LogManager.getLogger(...) call onto multiple lines to stay under 120 characters.

You can also share your feedback on Copilot code review. Take the survey.

milanmajchrak added a commit that referenced this pull request Mar 13, 2026
* Reduce warn logs noise (#1268)

* Log 404 responses at DEBUG instead of WARN to reduce log noise

* Log 404 responses at DEBUG instead of WARN (configurable via logging.server.debug-404)

* Skip stack trace extraction for suppressed 404 debug logs

* Replace custom debug-404 property with dedicated Log4j2 logger (org.dspace.app.rest.NotFound)

* Suppress 404 warn logs via dedicated Log4j2 logger (org.dspace.app.rest.NotFound)

* Turn off that warn logs for the dspace.log

* Updated log name to be more unique

* The row lenght was updated to be less than 120 chars (#1274)
milanmajchrak added a commit that referenced this pull request Mar 16, 2026
* Reduce warn logs noise (#1268) + line length fix (#1274)

* Fix flaky WorkflowCurationIT by clearing plugin cache before test

WorkflowCurationIT.curationTest fails when CreateMissingIdentifiersIT runs first,
because it pollutes the shared named plugin cache in LegacyPluginServiceImpl.

Port upstream fix from DSpace#11907 (dspace-7_x backport):
add clearNamedPluginClasses() call at test start to reset plugin state.

See: DSpace#8533
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants