VSB-TUO/Reduce warn logs noise - 404 dedicated logger#1277
Merged
milanmajchrak merged 2 commits intocustomer/vsb-tuofrom Mar 13, 2026
Merged
VSB-TUO/Reduce warn logs noise - 404 dedicated logger#1277milanmajchrak merged 2 commits intocustomer/vsb-tuofrom
milanmajchrak merged 2 commits intocustomer/vsb-tuofrom
Conversation
* Log 404 responses at DEBUG instead of WARN to reduce log noise * Log 404 responses at DEBUG instead of WARN (configurable via logging.server.debug-404) * Skip stack trace extraction for suppressed 404 debug logs * Replace custom debug-404 property with dedicated Log4j2 logger (org.dspace.app.rest.NotFound) * Suppress 404 warn logs via dedicated Log4j2 logger (org.dspace.app.rest.NotFound) * Turn off that warn logs for the dspace.log * Updated log name to be more unique
There was a problem hiding this comment.
Pull request overview
Reduces REST API log noise by routing expected 404 NOT_FOUND responses to a dedicated Log4j2 logger that is OFF by default, while keeping other client/server errors logged as before.
Changes:
- Add a dedicated Log4j2 logger configuration for 404 NOT_FOUND responses (default OFF).
- Introduce a
notFoundLoglogger and centralize 4xx logging vialogClientError(..)inDSpaceApiExceptionControllerAdvice. - Minor cleanup to keep log statements concise and within line-length limits.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| dspace/config/log4j2.xml | Adds dedicated 404 logger configuration (OFF by default). |
| dspace-server-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java | Routes 404s to a dedicated logger and refactors 4xx WARN logging into a helper. |
You can also share your feedback on Copilot code review. Take the survey.
...r-webapp/src/main/java/org/dspace/app/rest/exception/DSpaceApiExceptionControllerAdvice.java
Show resolved
Hide resolved
milanmajchrak
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of commits 1dc5339 and db67645 into customer/vsb-tuo.
Problem description
Original commits: