Skip to content

MENDELU/Added a new search filter by accesioned date#1291

Merged
milanmajchrak merged 1 commit intocustomer/mendelufrom
mendelu/add-new-filter
Mar 20, 2026
Merged

MENDELU/Added a new search filter by accesioned date#1291
milanmajchrak merged 1 commit intocustomer/mendelufrom
mendelu/add-new-filter

Conversation

@milanmajchrak
Copy link
Collaborator

Problem description

Analysis

(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)

Problems

(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)

Manual Testing (if applicable)

Copilot review

  • Requested review from Copilot

Copilot AI review requested due to automatic review settings March 20, 2026 13:10
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new Discovery facet/filter for accessioned date (dc.date.accessioned) so it can be used in the sidebar facets and on the search filter page, and updates REST integration tests/matchers accordingly.

Changes:

  • Registers searchFilterDateAccessioned in the default Discovery sidebar facets and search filters.
  • Defines the new DiscoverySearchFilterFacet bean mapping to dc.date.accessioned with type=date and min/max exposure enabled.
  • Extends REST test matchers and min/max facet integration tests to include the new facet.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
dspace/config/spring/api/discovery.xml Adds searchFilterDateAccessioned facet/filter and wires it into the default Discovery configuration.
dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/FacetEntryMatcher.java Adds matchers for the new dateAccessioned facet (with and without min/max).
dspace-server-webapp/src/test/java/org/dspace/app/rest/DiscoveryRestControllerIT.java Updates min/max facet tests to expect the new facet in responses.
dspace-server-webapp/src/test/data/dspaceFolder/config/spring/api/test-discovery.xml Updates the test Discovery configuration to include the new facet/filter.

@milanmajchrak milanmajchrak merged commit 8f467ce into customer/mendelu Mar 20, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants