MENDELU/Added a new search filter by accesioned date#1291
Merged
milanmajchrak merged 1 commit intocustomer/mendelufrom Mar 20, 2026
Merged
MENDELU/Added a new search filter by accesioned date#1291milanmajchrak merged 1 commit intocustomer/mendelufrom
milanmajchrak merged 1 commit intocustomer/mendelufrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds a new Discovery facet/filter for accessioned date (dc.date.accessioned) so it can be used in the sidebar facets and on the search filter page, and updates REST integration tests/matchers accordingly.
Changes:
- Registers
searchFilterDateAccessionedin the default Discovery sidebar facets and search filters. - Defines the new
DiscoverySearchFilterFacetbean mapping todc.date.accessionedwithtype=dateand min/max exposure enabled. - Extends REST test matchers and min/max facet integration tests to include the new facet.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
dspace/config/spring/api/discovery.xml |
Adds searchFilterDateAccessioned facet/filter and wires it into the default Discovery configuration. |
dspace-server-webapp/src/test/java/org/dspace/app/rest/matcher/FacetEntryMatcher.java |
Adds matchers for the new dateAccessioned facet (with and without min/max). |
dspace-server-webapp/src/test/java/org/dspace/app/rest/DiscoveryRestControllerIT.java |
Updates min/max facet tests to expect the new facet in responses. |
dspace-server-webapp/src/test/data/dspaceFolder/config/spring/api/test-discovery.xml |
Updates the test Discovery configuration to include the new facet/filter. |
dspace-server-webapp/src/test/java/org/dspace/app/rest/DiscoveryRestControllerIT.java
Show resolved
Hide resolved
dspace-server-webapp/src/test/java/org/dspace/app/rest/DiscoveryRestControllerIT.java
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem description
Analysis
(Write here, if there is needed describe some specific problem. Erase it, when it is not needed.)
Problems
(Write here, if some unexpected problems occur during solving issues. Erase it, when it is not needed.)
Manual Testing (if applicable)
Copilot review