CNDB-16583: Add new param to failure callback messages - verb name of the incoming message.#2244
Merged
MSpryszynski merged 2 commits intomainfrom Apr 9, 2026
Merged
CNDB-16583: Add new param to failure callback messages - verb name of the incoming message.#2244MSpryszynski merged 2 commits intomainfrom
MSpryszynski merged 2 commits intomainfrom
Conversation
Checklist before you submit for review
|
| */ | ||
| TRACE_KEYSPACE (8, "TraceKeyspace", StringSerializer.serializer), | ||
| /** | ||
| * Failure callback messages contain verb name of the incoming message. |
Collaborator
There was a problem hiding this comment.
Nit: Failure response messages... might sounds more clear?
niksajakovljevic
approved these changes
Mar 3, 2026
Collaborator
niksajakovljevic
left a comment
niksajakovljevic
left a comment
There was a problem hiding this comment.
LGTM. Can you please inspect the test failures (for some reason I can't access Butler atm).
| public Message<RequestFailureReason> failureResponse(RequestFailureReason reason) | ||
| { | ||
| return failureResponse(id(), expiresAtNanos(), reason); | ||
| return failureResponse(id(), expiresAtNanos(), reason, verb()); |
Collaborator
There was a problem hiding this comment.
Let's test this function as well. Is verb() returning request verb or the verb of the new response message we have built?
Collaborator
niksajakovljevic
left a comment
niksajakovljevic
left a comment
There was a problem hiding this comment.
Let's add test for failureResponse(RequestFailureReason reason) to make sure we use the correct verb().
niksajakovljevic
requested changes
Mar 3, 2026
Author
4 of them have open ticket with the same failure stack. Other 2 are failing for other open PRs too. |
… the incoming message.
❌ Build ds-cassandra-pr-gate/PR-2244 rejected by Butler7 regressions found Found 7 new test failures
Found 2 known test failures |
|
niksajakovljevic
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the issue
We want to use the messaging filter to collect metrics for failure responses coming from writer instances. To properly handle different types of failed requests (Read/Write), we need a way to distinguish between callback responses.
Fixes https://github.com/riptano/cndb/issues/16583
What does this PR fix and why was it fixed
This PR adds a new parameter to failure callback messages—the verb name of the incoming request. This parameter allows us to differentiate failure responses based on the origin of the request.