CNDB-17161: Add more logging to SAI initialization code#2282
Open
pkolaczk wants to merge 2 commits intocndb-main-release-202604from
Open
CNDB-17161: Add more logging to SAI initialization code#2282pkolaczk wants to merge 2 commits intocndb-main-release-202604from
pkolaczk wants to merge 2 commits intocndb-main-release-202604from
Conversation
Checklist before you submit for review
|
niksajakovljevic
approved these changes
Mar 20, 2026
adelapena
approved these changes
Mar 20, 2026
| { | ||
| try | ||
| { | ||
| logger.debug("IndexBuildDecider#onInitialBuild for index {} returned {}", index.getIndexMetadata().name, IndexBuildDecider.instance.onInitialBuild()); |
There was a problem hiding this comment.
Maybe add the keyspace name too?
Suggested change
| logger.debug("IndexBuildDecider#onInitialBuild for index {} returned {}", index.getIndexMetadata().name, IndexBuildDecider.instance.onInitialBuild()); | |
| logger.debug("IndexBuildDecider#onInitialBuild for index {}.{} returned {}", | |
| keyspace, index.getIndexMetadata().name, IndexBuildDecider.instance.onInitialBuild()); |
| // if there's no initialization, just mark as built (if it should be queryable) and return: | ||
| if (initialBuildTask == null) | ||
| { | ||
| logger.debug("No initialization task for index [{}], assuming index is built", index.getIndexMetadata().name); |
There was a problem hiding this comment.
Maybe add the keyspace name too?
Suggested change
| logger.debug("No initialization task for index [{}], assuming index is built", index.getIndexMetadata().name); | |
| logger.debug("No initialization task for index [{}.{}], assuming index is built", keyspace.getName(), index.getIndexMetadata().name); |
| if (IndexBuildDecider.instance.isIndexQueryableAfterInitialBuild(baseCfs)) | ||
| markIndexBuilt(index, true); | ||
| else | ||
| logger.debug("Not marking index [{}] as built because IndexBuildDecider#isIndexQueryableAfterInitialBuild returned false", index.getIndexMetadata().name); |
There was a problem hiding this comment.
Suggested change
| logger.debug("Not marking index [{}] as built because IndexBuildDecider#isIndexQueryableAfterInitialBuild returned false", index.getIndexMetadata().name); | |
| logger.debug("Not marking index [{}.{}] as built because IndexBuildDecider#isIndexQueryableAfterInitialBuild returned false", | |
| keyspace.getName(), index.getIndexMetadata().name); |
|
❌ Build ds-cassandra-pr-gate/PR-2282 rejected by Butler8 regressions found Found 8 new test failuresFound 3 known test failures |
pkolaczk
force-pushed
the
cndb-main-release-202604
branch
from
7cc369f to
609f428
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.