Skip to content

fix for bug causing tests to use FP vectors in search #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
MarkWolters wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix for bug causing tests to use FP vectors in search #645

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d27da63
fix for bug causing tests to use FP vectors in search
MarkWolters Mar 11, 2026
591c507
adding safeguards and logging
MarkWolters Mar 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 30 additions & 2 deletions jvector-examples/src/main/java/io/github/jbellis/jvector/example/Grid.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,7 @@ static void runOneGraph(OnDiskGraphIndexCache cache,
CompressedVectors cv;
if (featureSetForIndex.contains(FeatureId.FUSED_PQ)) {
cv = null;
System.out.format("%s: configured to use FUSED PQ, skipping vector compression%n", ds.getName());
} else {
constructionMetrics.resetSearch(); // per (index, cpSupplier) config

Expand All @@ -312,11 +313,17 @@ static void runOneGraph(OnDiskGraphIndexCache cache,

if (compressor == null) {
cv = null;
System.out.format("%s: No search compressor configured, FULL PRECISION vectors will be used for search%n", ds.getName());
} else {
long start = System.nanoTime();
cv = constructionMetrics.search(searchQuantType)
.timeEncode(() -> compressor.encodeAll(ds.getBaseRavv()));
double encodingTimeS = (System.nanoTime() - start) / 1_000_000_000.0;
if (cv == null) {
throw new IllegalStateException(String.format(
"Compressor '%s' was provided but failed to encode vectors for dataset '%s'. " +
"Aborting to prevent false recall results.", compressor, ds.getName()));
}
System.out.format("%s: %s encoded %d vectors [%.2f MB] in %.2fs%n", ds.getName(), compressor, ds.getBaseVectors().size(), (cv.ramBytesUsed() / 1024f / 1024f), encodingTimeS);
}
}
Expand Down Expand Up @@ -830,8 +837,29 @@ public static List<BenchResult> runAllAndCollectResults(

var compressor = getCompressor(buildCompressor, ds);
var searchCompressorObj = getCompressor(searchCompressor, ds);
CompressedVectors cvArg = (searchCompressorObj instanceof CompressedVectors) ? (CompressedVectors) searchCompressorObj : null;

// Encode vectors for reranking if a compressor is provided
CompressedVectors cvArg;
if (features.contains(FeatureId.FUSED_PQ)) {
cvArg = null;
System.out.format("%s: configured to use FUSED PQ, skipping vector compression%n", ds.getName());
} else {
if (searchCompressorObj == null) {
cvArg = null;
System.out.format("%s: No search compressor configured, " +
"FULL PRECISION vectors will be used for search%n", ds.getName());
} else {
cvArg = searchCompressorObj.encodeAll(ds.getBaseRavv());
if (cvArg == null) {
throw new IllegalStateException(String.format(
"Compressor '%s' was provided but failed to encode vectors for dataset '%s'. " +
"Aborting to prevent false recall results.",
searchCompressorObj, ds.getName()));
}
System.out.format("%s: %s encoded %d vectors [%.2f MB] for search%n",
ds.getName(), searchCompressorObj, ds.getBaseVectors().size(),
(cvArg.ramBytesUsed() / 1024f / 1024f));
}
}
// If cache is disabled, we use the (tmp) testDirectory as the output
Path outputDir = cache.isEnabled() ? cache.cacheDir().toAbsolutePath() : testDirectory;

Expand Down
Loading