[pull] dev from KelvinTegelaar:dev #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dawsobr2
pushed a commit
that referenced
this pull request
Feb 26, 2024
[pull] master from KelvinTegelaar:master
Changed URL structure for Add and Remove service principal alerts: - Updated path from /tenant/administration/enterprise-apps to /tenant/administration/applications/enterprise-apps - Changed query parameter from customerId=?customerId= to tenantFilter= with tenant default domain - Fixes incorrect URL generation that was using double customerId parameter Co-authored-by: Zacgoose <107489668+Zacgoose@users.noreply.github.com>
Corrected the IntroText to say "has been removed" instead of "has been added" for the Remove service principal operation to match the actual action being performed. Co-authored-by: Zacgoose <107489668+Zacgoose@users.noreply.github.com>
…ert-url Fix service principal alert URL structure
Added overwrite toggle for transport rule standard
Adds duplicate RowKey checks to prevent race conditions when creating scheduled tasks. Enhances rerun protection logic in Push-ExecScheduledCommand to avoid duplicate executions within recurrence intervals. Refines orchestrator task state transitions and filtering for stuck tasks. Improves logging and filtering for scheduled item listing, and updates Test-CIPPRerun to support custom intervals and base times for scheduled tasks.
Refactored Add-CIPPDbItem to process data in batches, reducing memory usage when handling large datasets. Updated Push-StoreMailboxPermissions and Set-CIPPDBCacheUsers to use generic lists and explicit cleanup for better memory management. Added new Set-CIPPDBCacheCASMailboxes function to cache CAS mailboxes, and registered 'CASMailboxes' in Push-CIPPDBCacheData. These changes enhance reliability and scalability when caching large volumes of data.
- Updated Set-CIPPNamedLocation to handle multiple IPs and locations for removal. - Enhanced Invoke-ExecNamedLocation to correctly process input values.
- Updated Set-CIPPNamedLocation to handle multiple IPs and locations for removal. - Enhanced Invoke-ExecNamedLocation to correctly process input values.
…into named-locations
Add-CIPPDbItem.ps1 now dynamically calculates batch size based on available memory and estimated item size, improving efficiency and stability for large datasets. Both Add-CIPPDbItem.ps1 and Set-CIPPDBCacheUsers.ps1 now include enhanced error logging with detailed exception data using Get-CippException.
Reduced the maximum batch size from 2000 to 500 to prevent out-of-memory errors with large datasets. Updated the information log to include target memory and calculated batch size for better diagnostics.
Enhanced memory cleanup in Add-CIPPDbItem and Set-CIPPDBCacheUsers by explicitly clearing variables and invoking garbage collection with logging. Optimized hashtable property removal in Add-CIPPAzDataTableEntity for better performance and reliability.
This reverts commit f8670f8.
Refactors Add-CIPPApplicationPermission to batch-create missing service principals and apply app role assignments using Microsoft Graph bulk requests. This improves efficiency and error handling when processing multiple permissions and service principals.
Added informational logging to Add-CIPPApplicationPermission for better traceability. Updated Invoke-ExecCPVRefresh to nest InstanceId under Metadata in the response body for improved response structure.
- Update product display names in ExcludeSkuList.JSON to match authoritative license data. - Implemented syncing logic in Update-LicenseSKUFiles.ps1 to automate updates.
Feat: Support removal of multiple IPs and locations
Chore: Sync product names in ExcludeSkuList.JSON
Add-CIPPDbItem now supports pipeline input for memory-efficient streaming, improved batch processing, and automatic count recording via -AddCount. Updated related cache scripts to use streaming and batch features, reducing memory usage and simplifying code. Added Set-CIPPDbCacheTestData.ps1 for generating large test datasets. Enhanced Add-CIPPAzDataTableEntity with performance logging.
…IPPDbItem Eliminated detailed timing and debug output from Add-CIPPAzDataTableEntity.ps1 to reduce log verbosity and improve performance. Commented out Write-Debug statements in Add-CIPPDbItem.ps1 and added property selection to Get-CIPPAzDataTableEntity for efficiency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )