Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request modernizes and migrates the
react-native-quick-firebaselibrary to support React Native's New Architecture, including TurboModules and codegen. It updates both Android and iOS native modules, simplifies the JavaScript interface, and bumps the package to version 2.0.0. The changes improve compatibility, maintainability, and performance for newer React Native projects.New Architecture & TurboModule Migration:
RNQuickFirebasenow extends generated specs and implements TurboModule interfaces) [1] [2] [3] [4] [5].TurboModuleRegistry.getEnforcinginstead ofNativeModules, and simplified method signatures and error handling [1] [2].Android Build & Code Updates:
iOS Build & Code Updates:
.mm), implemented TurboModule and codegen interfaces, and improved error handling and method signatures [1] [2].Firebase/Authas a dependency [1] [2].Package & Codegen Configuration:
react-nativepeer dependency to>=0.71.0[1] [2].codegenConfigfor automatic code generation and included TypeScript as a dev dependency.Removed Legacy Code:
RNQuickFirebase.min favor of the new Objective-C++ TurboModule implementation.These changes collectively bring the library up to date with the latest React Native standards and tooling, ensuring better performance and compatibility with modern projects.