Allow more characters in passwords read from file#1806
Open
rolandwalker wants to merge 1 commit intomainfrom
Open
Allow more characters in passwords read from file#1806rolandwalker wants to merge 1 commit intomainfrom
rolandwalker wants to merge 1 commit intomainfrom
Conversation
rolandwalker
force-pushed
the
RW/allow-more-characters-password-from-file
branch
from
507e4c8 to
96942c0
Compare
strip() with no arguments would mean that a password read from a file
could not contain a leading space. While that is unusual, it is also
true that in such an edge case, the use of the password file would be
more likely to manage the weird string.
removesuffix('\n') should be the most targeted possible cleanup.
rolandwalker
force-pushed
the
RW/allow-more-characters-password-from-file
branch
from
96942c0 to
eb616aa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
strip()with no argument would mean that a password read from a file could not contain a leading space. While that is unusual, it is also true that in such an edge case, the use of the password file would be more likely to manage the weird string.removesuffix('\n')should be the most targeted possible cleanup.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).