Move prompt-format methods to main_modes/repl.py#1821
Merged
rolandwalker merged 1 commit intomainfrom Apr 5, 2026
Merged
Conversation
Move these methods to main_modes/repl.py: * set_all_external_titles() * set_external_terminal_tab_title() * set_external_terminal_window_title() * set_external_multiplex_window_title() * set_external_multiplex_pane_title() * get_custom_toolbar() * get_prompt() and other rearrangements needed to effect that change. After the changes, main.py still has two calls to the new functions, which are marked with todo comments regarding the incomplete separation.
rolandwalker
force-pushed
the
RW/move-prompt-string-methods-to-repl-py
branch
from
a4122e8 to
e7c606f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Move these methods to
main_modes/repl.py:set_all_external_titles()set_external_terminal_tab_title()set_external_terminal_window_title()set_external_multiplex_window_title()set_external_multiplex_pane_title()get_custom_toolbar()get_prompt()and other rearrangements needed to effect that change.
After the changes,
main.pystill has two calls to the new functions, which are marked with todo comments regarding the incomplete separation.Checklist
changelog.mdfile.AUTHORSfile (or it's already there).