Conversation
The previous logic for loading a workspace would only attempt to fall back to the last known conversation if the active one was missing. But if the active conversation *is* the last known conversation, it would retry the same conversation again, and then fail. JP now iterates backwards through the entire history of available conversation IDs until it finds a valid metadata file on disk. This improves the resilience of the workspace loading process when conversation files have been manually deleted or moved outside of the application. Signed-off-by: Jean Mertz <git@jeanmertz.com>
… missing Signed-off-by: Jean Mertz <git@jeanmertz.com>
… missing Signed-off-by: Jean Mertz <git@jeanmertz.com>
… missing Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous logic for loading a workspace would only attempt to fall back to the last known conversation if the active one was missing. But if the active conversation is the last known conversation, it would retry the same conversation again, and then fail.
JP now iterates backwards through the entire history of available conversation IDs until it finds a valid metadata file on disk. This improves the resilience of the workspace loading process when conversation files have been manually deleted or moved outside of the application.