Conversation
Previously, `--cfg` path resolution only searched for files relative to the workspace root. This made it impossible to define personal configuration fragments that apply across all workspaces (in the user-global root) or fragments scoped to a single workspace but kept private (in the user-workspace root). This commit implements RFD 035, extending `--cfg` resolution to search across three config roots in precedence order: 1. User-global: `$XDG_CONFIG_HOME/jp/config/` 2. Workspace: `<workspace_root>/` 3. User-workspace: `$XDG_DATA_HOME/jp/workspace/<id>/config/` When a `--cfg` path is provided, JP now searches each root independently. If matching files are found in multiple roots, they are all loaded and merged in precedence order (highest precedence wins). Within a single root, the existing "first match wins" behavior for entries in `config_load_paths` is preserved. Additionally, the `MissingConfigFile` error now includes a list of all locations that were searched, improving the debugging experience when a config fragment cannot be found. For example, running `jp --cfg skill/web` will now search for and merge matches from your global config, the current workspace, and your workspace-specific private config. Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
Signed-off-by: Jean Mertz <git@jeanmertz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
--cfgpath resolution only searched for files relative to the workspace root. This made it impossible to define personal configuration fragments that apply across all workspaces (in the user-global root) or fragments scoped to a single workspace but kept private (in the user-workspace root).This commit implements RFD 035, extending
--cfgresolution to search across three config roots in precedence order:$XDG_CONFIG_HOME/jp/config/<workspace_root>/$XDG_DATA_HOME/jp/workspace/<id>/config/When a
--cfgpath is provided, JP now searches each root independently. If matching files are found in multiple roots, they are all loaded and merged in precedence order (highest precedence wins). Within a single root, the existing "first match wins" behavior for entries inconfig_load_pathsis preserved.Additionally, the
MissingConfigFileerror now includes a list of all locations that were searched, improving the debugging experience when a config fragment cannot be found.For example, running
jp --cfg skill/webwill now search for and merge matches from your global config, the current workspace, and your workspace-specific private config.