fix: handle shape mismatch in gp_regression test with squeeze()#102
Open
bugparty wants to merge 1 commit into
Open
fix: handle shape mismatch in gp_regression test with squeeze()#102bugparty wants to merge 1 commit into
bugparty wants to merge 1 commit into
Conversation
When J=1, preds has shape (2,1) but gold_preds has shape (2,), causing assert_almost_equal to fail. Apply .squeeze() to both arrays to ensure compatible shapes before comparison. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
test_gp_regression, when J=1,predshas shape(2,1)butgold_predshas shape(2,), causingassert_almost_equalto fail due to shape mismatch.squeeze()to both arrays before comparison, ensuring compatible shapes regardless of JTest plan
test_gp_regressiondirectly — all 3 iterations passedpytest numpy_ml/tests/test_nonparametric.py) — blocked by pre-existing Python 3.13 import error (collections.Hashableremoved), unrelated to this change🤖 Generated with Claude Code