Open
Conversation
Codex-generated pull request Improves documentation to adhere to style guidelines.
Author
|
The code is slightly longer than strictly necessary, as I had to test it with limited computational resources and therefore implemented checkpointing etc. I am happy to remove these parts if preferred. I could also add the input files to the repository. They are around 300 KB in total, so it might be worth considering whether they should instead be hosted externally. Currently, I only generate a parity plot of the density. If it would be of interest, I could also include additional plots, such as density or excess volume as a function of ethanol concentration. I would need to check how. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-review checklist for PR author
PR author must check the checkboxes below when creating the PR.
Summary
Benchmark of the density of water-ethanol mixtures using NPT MD, compare to experiment.
Linked issue
Resolves #352
Progress
Testing
Tested on mace-mp-0b3 using lower cost simulation settings.
(reduced dispersion cutoff, shorter time, etc.)
New decorators/callbacks
None (yet)