Enforce strict type checking across Python and TypeScript#270
Merged
Conversation
Contributor
🚀 Preview DeploymentsCode Server (Full VS Code Extension)Browser-based VS Code with the Debrief extension and sample data pre-installed. Web Shell (Standalone App)Use this for Playwright testing and demos - runs outside Storybook. Storybook (Component Library)Browse all components, stories, and documentation. All Links
|
Specify strict type safety across Python and TypeScript domains: - Feature spec with 5 user stories covering local dev, CI, constitution, codebase remediation, and cross-language schema consistency - Add Article XV to CONSTITUTION.md mandating strict types, prohibiting Any/any, and requiring CI enforcement - Quality checklist passes all validation items https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
Address the pattern where tool parameters use generic Record<string, unknown> instead of per-tool typed interfaces (~24 occurrences across the codebase). Generic dictionaries defeat static analysis and are treated as equivalent to `any`. https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
Tool parameters should reference existing concrete type declarations from the schema/type system, not create bespoke per-tool interfaces. https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
Phase 0: research.md — pyright over mypy, ESLint gap analysis, schema generator audit, CI pipeline design, ruff rule additions Phase 1: plan.md, data-model.md, quickstart.md, contracts (pyright, ESLint, ruff, CI pipeline) Phase 2: planning post and LinkedIn summary https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
80 tasks across 8 phases: - Phase 1: Setup (pyright, ruff ANN/TC rules) - Phase 2: Foundation (ESLint consistency across 8 TS packages) - Phase 3: Constitution verification (Article XV) - Phase 4: Developer workflow verification - Phase 5: Schema generation post-processing - Phase 6: Codebase remediation (~208 violations across 49 files) - Phase 7: CI pipeline enforcement - Phase 8: Polish, evidence collection, media, PR https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
- Add pyright 1.1+ to dev dependencies (standard mode, 132 baseline errors) - Create pyrightconfig.json covering all Python packages - Add ANN (annotation presence) and TC (type-checking imports) to ruff - Ignore deprecated ANN101/ANN102 (self/cls for Python 3.11+) - Ruff ANN baseline: 1063 violations https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
- apps/vscode: add no-explicit-any: error - apps/loader: add no-explicit-any: error - shared/components: promote no-explicit-any from off to error, remove blanket test file override - apps/web-shell: add strict: true to tsconfig.node.json, add typecheck script https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
- Add Article XV to .specify/memory/constitution.md cache - Post-process gen-pydantic output: replace dict[str, Any] with dict[str, object] in boilerplate classes (ConfiguredBaseModel, LinkMLMeta) - Remove unused Any import from generated Python https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
- Add task typecheck to Taskfile.yml (uv run pyright + pnpm -r typecheck) - Add type checking step to ci.yml between lint and test https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
…hase 6b Replace `any` with proper typed interfaces across VS Code tests, shared components, web-shell services, and session-state tests. All 1177 tests pass (571 components + 291 vscode + 572 session-state + others). https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
… Phase 6a Python: add return type annotations to CLI commands, replace Any with object in output.py where safe, add JSON-serializable comments to legitimate Any fields. Pyright stays at 132 errors (no regressions). TypeScript: improve toolService.ts type safety with asToolFn wrapper. https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
…hase 8 - Fix last 2 no-explicit-any in useTreeState.test.ts (0 remaining) - Create evidence: test-summary.md, usage-example.md, violation-inventory.md, pyright-output.txt, eslint-output.txt - Create media: shipped-post.md, linkedin-shipped.md - Mark all 80 tasks complete in tasks.md https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
Lock file update from adding pyright>=1.1.0 to dev dependencies. https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
IanMayo
force-pushed
the
claude/strict-type-checking-WoO58
branch
from
f8e3db7 to
f60b625
Compare
- Add return type annotations (-> None, -> specific types) to all public functions, test methods, and pytest fixtures (ANN201/ANN202) - Add parameter type annotations to all function arguments including pytest fixture parameters (ANN001/ANN002/ANN003) - Add -> None to all __init__ methods (ANN204) - Move imports into TYPE_CHECKING blocks where safe (TC003/TC005) - Keep Callable at runtime in models.py (Pydantic needs it) - Use ParamSpec/TypeVar for typed decorator wrapper in registry.py - Replace Any with object/specific types where ANN401 flagged - Remove unused imports/vars in TS test files (ESLint no-unused-vars) - All 869 Python tests pass, all TS tests pass, 0 lint errors https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
- mcp/server.py: use TYPE_CHECKING imports for conditional MCP SDK - provenance.py: use Pydantic alias names in LogEntry/WasGeneratedBy constructors - registry.py: use setattr for dynamic tool attribute on wrapper function - test_exceptions.py: correct Never→None return type - test_executor.py: add assert narrowing for Optional fields - test_models.py: use Pydantic aliases + Optional narrowing + type: ignore for intentional validation error tests - test_buffer_zone_generator.py: explicit sensor_model param, float tuples, Any return - cli/tools.py: add assert for result.error + type: ignore for recursive coords - config/core.py: use Pydantic alias lastAccessed - config/storage.py: Callable[[Config], Config] instead of lowercase callable - test_decorators.py: getattr for dynamic __tool_spec__ attribute - symbols.py: guard None line_style before dict.get() - test_coordinates.py, test_timestamps.py: assert not None before unpacking - test_client.py: type: ignore for unresolvable debrief_session import - stac catalog.py, conftest.py, test_catalog.py: use datetime alias for PlotMetadata - test_coverage.py: type: ignore for intentional bad input test - test_stac_validation.py: assert stac_validator not None before usage pyright: 0 errors, 0 warnings | ruff: all checks passed | pytest: 869 passed https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
26 findings from static analysis comparing CONSTITUTION.md, ARCHITECTURE.md, and TOOL-RESULTS.md against actual implementation. 1 blocking, 7 significant, 7 minor, 11 informational.
…acement - getState.ts: add drawingPaletteIndex to SpatialSlice, styleVersion to FeaturesSlice to match updated type definitions - test_decorators.py: move noqa: B009 comments after == comparison (were incorrectly placed before, turning comparisons into comments) https://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj
Promote F-1.5 (provenance) and F-2.2 (kind values) to blocking. Reclassify F-3.3, F-5.2 as drift. Promote F-2.4, F-2.6, F-5.1. Defer F-4.1 pending results strategy. Add disposition notes throughout.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements strict type safety across the codebase by adding pyright for Python static type checking, promoting ESLint's
no-explicit-anyrule to error across all TypeScript packages, and replacing ~208 existingAny/anyviolations with concrete types. Type checking is now a CI gate that blocks merges on violations.Key Changes
Configuration & Tooling
pyrightconfig.jsonat repo root with standard mode type checking for all Python packagesruff.tomlto includeANN(annotation presence) andTC(type checking) rule setspyright>=1.1.0topyproject.tomldev dependencies@typescript-eslint/no-explicit-any: error:apps/vscode/.eslintrc.jsonapps/loader/.eslintrc.cjsshared/components/.eslintrc.cjsstrict: truetoapps/web-shell/tsconfig.node.jsontypecheckscript toapps/web-shell/package.jsonCI Integration
typechecktask toTaskfile.ymlthat runsuv run pyrightandpnpm -r typecheck.github/workflows/ci.ymlto run type checking between lint and test stepsType Safety Fixes
Replaced
anywith concrete types in test files:apps/vscode/tests/__mocks__/vscode.ts: AddedMockUri,MockCommand,MockThemeIconinterfacesapps/vscode/tests/unit/labelInterval.test.ts,setTrackColor.test.ts,symbolInterval.test.ts: ReplacedanywithTestTrackFeatureinterfaceshared/components/src/MapView/__tests__/temporal-utils.test.ts: ReplacedanywithTestFeatureInputinterfaceshared/components/src/MapView/__tests__/selection.test.tsx: Typed mock props instead of usinganyapps/vscode/tests/unit/openPlotsService.test.ts: AddedMockWorkspaceStateinterfaceapps/vscode/tests/unit/generateReferencePoints.test.ts: AddedGoldenFileinterfaceapps/web-shell/src/mocks/calcService.ts: Removedanytype assertionsshared/components/src/MapView/MapView.tsx: Removedeslint-disablecomment foranyusageshared/components/src/MapView/__fixtures__/exerciseAlpha.ts: Removedeslint-disablecommentAdded type annotations to Python functions:
services/cli/debrief_cli/tools.py: Added-> Nonereturn type totools()functionservices/cli/debrief_cli/output.py: Added-> Nonereturn type to__init__()methodUpdated
apps/web-shell/src/services/toolService.ts: Replacedas anycast withas unknown as ToolExecuteFnand addedToolExecuteFntype definitionUpdated
shared/schemas/scripts/generate.py: Added post-processing to replacedict[str, Any]withdict[str, object]in generated Pydantic boilerplateConstitutional & Documentation
CONSTITUTION.mdwith Article XV mandating strict type safety with 6 specific mandates.specify/memory/constitution.mdto sync Article XVCLAUDE.mdto document pyright as an active technologyspecs/098-strict-type-checking/:spec.md: Feature specification with user stories and acceptance criteriaplan.md: Implementation plan with technical contextresearch.md: Research decisions (pyright selection, TypeScript state)quickstart.md: Developer workflow guidehttps://claude.ai/code/session_0126Hrb5x1dQKCZ2UdkJsjSj