Skip to content

Release 1.8 debug #2283

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Isteb4k wants to merge 1 commit into
base: release-1.8
Choose a base branch
from
Draft

Release 1.8 debug #2283

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions images/virtualization-artifact/pkg/controller/vd/internal/source/object_ref_vi.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,9 @@ import (
"context"
"errors"
"fmt"
"reflect"

"github.com/deckhouse/virtualization-controller/pkg/logger"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/types"
cdiv1 "kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1"
Expand Down Expand Up @@ -71,6 +73,8 @@ func (ds ObjectRefVirtualImage) Sync(ctx context.Context, vd *v1alpha2.VirtualDi
return reconcile.Result{}, fmt.Errorf("fetch dv: %w", err)
}

logger.FromContext(ctx).Info("[GOGOGO] Reconcile virtual disk", "datavolume", safenil(dv), "pvc", safenil(pvc))

return steptaker.NewStepTakers[*v1alpha2.VirtualDisk](
step.NewReadyStep(ds.diskService, pvc, cb),
step.NewTerminatingStep(pvc),
Expand All @@ -81,6 +85,14 @@ func (ds ObjectRefVirtualImage) Sync(ctx context.Context, vd *v1alpha2.VirtualDi
).Run(ctx, vd)
}

func safenil(o client.Object) string {
if o == nil || reflect.ValueOf(o).IsNil() {
return "nil"
}

return o.GetName()
}

func (ds ObjectRefVirtualImage) Validate(ctx context.Context, vd *v1alpha2.VirtualDisk) error {
if vd.Spec.DataSource == nil || vd.Spec.DataSource.ObjectRef == nil {
return errors.New("object ref missed for data source")
Expand Down
3 changes: 3 additions & 0 deletions .../virtualization-artifact/pkg/controller/vd/internal/source/step/create_dv_from_vi_step.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@ import (
"errors"
"fmt"

"github.com/deckhouse/virtualization-controller/pkg/logger"
corev1 "k8s.io/api/core/v1"
"k8s.io/apimachinery/pkg/api/resource"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -69,6 +70,8 @@ func (s CreateDataVolumeFromVirtualImageStep) Take(ctx context.Context, vd *v1al
return nil, nil
}

logger.FromContext(ctx).Info("[GOGOGO] STEP CreateDataVolumeFromVirtualImageStep")

viRefKey := types.NamespacedName{Name: vd.Spec.DataSource.ObjectRef.Name, Namespace: vd.Namespace}
viRef, err := object.FetchObject(ctx, viRefKey, s.client, &v1alpha2.VirtualImage{})
if err != nil {
Expand Down
24 changes: 24 additions & 0 deletions images/virtualization-artifact/pkg/controller/vd/internal/source/step/wait_for_dv_step.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,10 @@ package step
import (
"context"
"fmt"
"reflect"
"strings"

"github.com/deckhouse/virtualization-controller/pkg/logger"
corev1 "k8s.io/api/core/v1"
storagev1 "k8s.io/api/storage/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
Expand Down Expand Up @@ -66,13 +68,25 @@ func NewWaitForDVStep(
}
}

func safenil(o client.Object) string {
if o == nil || reflect.ValueOf(o).IsNil() {
return "nil"
}

return o.GetName()
}

func (s WaitForDVStep) Take(ctx context.Context, vd *v1alpha2.VirtualDisk) (*reconcile.Result, error) {
logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep", "datavolume", safenil(s.dv), "sc", vd.Status.StorageClassName)

if s.dv == nil {
vd.Status.Phase = v1alpha2.DiskProvisioning
s.cb.
Status(metav1.ConditionFalse).
Reason(vdcondition.Provisioning).
Message("Waiting for the VirtualDisk importer to be created.")

logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep [importer to be created]")
return &reconcile.Result{}, nil
}

Expand All @@ -88,11 +102,13 @@ func (s WaitForDVStep) Take(ctx context.Context, vd *v1alpha2.VirtualDisk) (*rec
return &reconcile.Result{}, nil
}
if set {
logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep [consumer awaited]")
return &reconcile.Result{}, nil
}

ok = s.checkRunningCondition(vd)
if !ok {
logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep [checkRunningCondition]")
return &reconcile.Result{}, nil
}

Expand All @@ -106,9 +122,12 @@ func (s WaitForDVStep) Take(ctx context.Context, vd *v1alpha2.VirtualDisk) (*rec

set = s.setForProvisioning(vd)
if set {
logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep [provisioning to the pvc]")
return &reconcile.Result{}, nil
}

logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep [ok]")

return nil, nil
}

Expand All @@ -126,6 +145,8 @@ func (s WaitForDVStep) setForProvisioning(vd *v1alpha2.VirtualDisk) (set bool) {
}

func (s WaitForDVStep) setForFirstConsumerIsAwaited(ctx context.Context, vd *v1alpha2.VirtualDisk) (set bool, err error) {
logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep setForFirstConsumerIsAwaited 111")

if vd.Status.StorageClassName == "" {
return false, fmt.Errorf("StorageClassName is empty, please report a bug")
}
Expand All @@ -138,6 +159,9 @@ func (s WaitForDVStep) setForFirstConsumerIsAwaited(ctx context.Context, vd *v1a
isWFFC := sc != nil && sc.VolumeBindingMode != nil && *sc.VolumeBindingMode == storagev1.VolumeBindingWaitForFirstConsumer
dvRunningCond, _ := conditions.GetDataVolumeCondition(conditions.DVRunningConditionType, s.dv.Status.Conditions)
dvRunningReasonEmptyOrPending := dvRunningCond.Reason == "" || dvRunningCond.Reason == conditions.DVRunningConditionPendingReason

logger.FromContext(ctx).Info("[GOGOGO] STEP WaitForDVStep setForFirstConsumerIsAwaited 222", "isWFFC", isWFFC, "dvPhase", s.dv.Status.Phase, "dvRunningReasonEmptyOrPending", dvRunningReasonEmptyOrPending)

if isWFFC && (s.dv.Status.Phase == cdiv1.PendingPopulation || s.dv.Status.Phase == cdiv1.WaitForFirstConsumer) && dvRunningReasonEmptyOrPending {
vd.Status.Phase = v1alpha2.DiskWaitForFirstConsumer
s.cb.
Expand Down
28 changes: 25 additions & 3 deletions images/virtualization-artifact/pkg/controller/vd/internal/watcher/datavolume_watcher.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,9 @@ package watcher

import (
"fmt"
"strings"

"github.com/deckhouse/deckhouse/pkg/log"
cdiv1 "kubevirt.io/containerized-data-importer-api/pkg/apis/core/v1beta1"
"sigs.k8s.io/controller-runtime/pkg/controller"
"sigs.k8s.io/controller-runtime/pkg/event"
Expand All @@ -31,10 +33,14 @@ import (
"github.com/deckhouse/virtualization/api/core/v1alpha2"
)

type DataVolumeWatcher struct{}
type DataVolumeWatcher struct {
logger *log.Logger
}

func NewDataVolumeWatcher() *DataVolumeWatcher {
return &DataVolumeWatcher{}
return &DataVolumeWatcher{
logger: log.Default().With("watcher", strings.ToLower("DataVolume")),
}
}

func (w *DataVolumeWatcher) Watch(mgr manager.Manager, ctr controller.Controller) error {
Expand All @@ -49,37 +55,53 @@ func (w *DataVolumeWatcher) Watch(mgr manager.Manager, ctr controller.Controller
predicate.TypedFuncs[*cdiv1.DataVolume]{
CreateFunc: func(e event.TypedCreateEvent[*cdiv1.DataVolume]) bool { return false },
UpdateFunc: func(e event.TypedUpdateEvent[*cdiv1.DataVolume]) bool {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed")

if e.ObjectOld.Status.Progress != e.ObjectNew.Status.Progress {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [e.ObjectOld.Status.Progress != e.ObjectNew.Status.Progress]")
return true
}

if e.ObjectOld.Status.Phase != e.ObjectNew.Status.Phase && e.ObjectNew.Status.Phase == cdiv1.Succeeded {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [e.ObjectNew.Status.Phase == cdiv1.Succeeded]")
return true
}

if e.ObjectOld.Status.ClaimName != e.ObjectNew.Status.ClaimName {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [e.ObjectOld.Status.ClaimName != e.ObjectNew.Status.ClaimName]")
return true
}

oldDVQuotaNotExceeded, oldOk := conditions.GetDataVolumeCondition(conditions.DVQoutaNotExceededConditionType, e.ObjectOld.Status.Conditions)
newDVQuotaNotExceeded, newOk := conditions.GetDataVolumeCondition(conditions.DVQoutaNotExceededConditionType, e.ObjectNew.Status.Conditions)

if !oldOk && newOk {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [quota]")
return true
}

if oldOk && newOk && oldDVQuotaNotExceeded != newDVQuotaNotExceeded {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [quota 2]")
return true
}

oldDVRunning, _ := conditions.GetDataVolumeCondition(conditions.DVRunningConditionType, e.ObjectOld.Status.Conditions)
newDVRunning, _ := conditions.GetDataVolumeCondition(conditions.DVRunningConditionType, e.ObjectNew.Status.Conditions)

if oldDVRunning.Reason != newDVRunning.Reason {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [oldDVRunning.Reason != newDVRunning.Reason]")
return true
}

return newDVRunning.Reason == "Error" || newDVRunning.Reason == "ImagePullFailed"
f := newDVRunning.Reason == "Error" || newDVRunning.Reason == "ImagePullFailed"
if f {
w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [oldDVRunning.Reason != newDVRunning.Reason]")
return true
}

w.logger.Info("[GOGOGO] [DataVolumeWatcher] Event observed [FALSE]")

return false
},
},
),
Expand Down
Loading