fix(github): accept more app key formats#383
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This updates the GitHub MCP auth helper to normalize GitHub App private keys before signing JWTs. It now accepts raw PEM values, single-line values with escaped newlines, base64-encoded PEM, and JSON-shaped secrets that contain a nested private key. The change also validates the PEM earlier so startup failures surface as a clear configuration error instead of an OpenSSL NO_START_LINE crash. README and .env example docs now include GITHUB_APP_ID and the supported GITHUB_PRIVATE_KEY formats.
Summary by cubic
Accepts more GitHub App private key formats and validates them early to prevent startup crashes when signing JWTs. Docs now list
GITHUB_APP_IDand explain supportedGITHUB_PRIVATE_KEYformats.GITHUB_PRIVATE_KEY: trims quotes, unescapes\n, reads JSON{privateKey|private_key}, and base64-decodes when needed.crypto.createPrivateKeyand surface a clear "Invalid GITHUB_PRIVATE_KEY" config error instead of an OpenSSL NO_START_LINE failure..env.examplewithGITHUB_APP_IDand key format guidance.Written for commit 082f080. Summary will update on new commits.