fix(github): handle raw DER keys and fix JSON-wrapped key parsing#384
Merged
fix(github): handle raw DER keys and fix JSON-wrapped key parsing#384
Conversation
The normalizePrivateKey function failed on keys without PEM headers (raw base64 DER) and on JSON-wrapped keys where \\n replacement ran before JSON.parse, corrupting the JSON string. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
NO_START_LINEPEM error by handling raw base64 DER keys (without-----BEGIN/END-----headers) — wraps them with PEM headers and validates using both PKCS#8 and PKCS#1\nreplacement, which was corrupting valid JSON stringsTest plan
\n, base64 PEM, raw base64 DER, no-newline PEM, JSON-wrapped, quoted PEM, PKCS#1 DER, base64url DERNO_START_LINEerror🤖 Generated with Claude Code
Summary by cubic
Fixes GitHub App private key parsing to accept raw DER and JSON‑wrapped keys, preventing NO_START_LINE errors. Improves reliability of JWT creation across different secret formats.
Written for commit f243c81. Summary will update on new commits.