Open
Conversation
Figma Dynamic Client Registration requires an X-Figma-Token header and specific client_name/scope values. This adds provider-specific handling in the OAuth proxy to inject the PAT and rewrite the registration body, plus UI hints for Figma connections. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
🧪 BenchmarkShould we run the Virtual MCP strategy benchmark for this PR? React with 👍 to run the benchmark.
Benchmark will run on the next push after you react. |
Contributor
Release OptionsSuggested: Minor ( React with an emoji to override the release type:
Current version:
|
Contributor
There was a problem hiding this comment.
1 issue found across 5 files
Prompt for AI agents (unresolved issues)
Check if these issues are valid — if so, understand the root cause of each and fix them. If appropriate, use sub-agents to investigate and fix each issue separately.
<file name="apps/mesh/src/api/app.ts">
<violation number="1" location="apps/mesh/src/api/app.ts:745">
P1: `scope` is defaulted, not ensured. Existing non-empty scopes that omit `mcp:connect` will bypass this logic and can break Figma registration.</violation>
</file>
Reply with feedback, questions, or to request a fix. Tag @cubic-dev-ai to re-run a review.
…a register Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
X-Figma-Tokenheader from connection PAT, rewritesclient_nameto"Claude Code (figma)", and ensuresscope: "mcp:connect"in the registration body*.figma.comURLs, shows PAT field with link to Figma developer settings)Test plan
https://mcp.figma.com/mcpbun run fmt,bun run lint,bun run checkpassbun testpasses (1534 pass, 32 skip)🤖 Generated with Claude Code
Summary by cubic
Adds Figma MCP support with PAT-based registration in the OAuth proxy and UI hints to add a Figma PAT, enabling reliable connection to
mcp.figma.com.X-Figma-Tokenon register, rewritesclient_nameto "Claude Code (figma)", always ensuresscope: "mcp:connect", and returns a clear 403 when the PAT is missing/invalid (viaisFigmaConnection).*.figma.comURLs, shows a Figma provider hint with aFigma PATfield (figd_…) and link to PAT settings; updates sidebar label, placeholder, and help text.Written for commit e50f17c. Summary will update on new commits.