ui: Fix wallet disable/enable targeting wrong wallet.#3586
Merged
Conversation
When ETH and Base are grouped under the same ticker, selectedWalletID was set once to ETH by setSelectedTicker and never updated when operating on Base via network actions or settings. This caused toggleWalletStatus to target the wrong wallet - e.g. enabling ETH instead of disabling Base. Set selectedWalletID in showReconfig so the disable/enable buttons in settings target the wallet being configured. Also always set selectedWalletID in showNetworkActions when showing the Enable action, not just for the token-disabled case.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When ETH and Base are grouped under the same ticker, selectedWalletID was set once to ETH by setSelectedTicker and never updated when operating on Base via network actions or settings. This caused toggleWalletStatus to target the wrong wallet - e.g. enabling ETH instead of disabling Base.
Set selectedWalletID in showReconfig so the disable/enable buttons in settings target the wallet being configured. Also always set selectedWalletID in showNetworkActions when showing the Enable action, not just for the token-disabled case.