-
Notifications
You must be signed in to change notification settings - Fork 3
feat: multi-provider support via OpenAI-compatible client #92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
在这段代码中,虽然对
modelBtn的内容进行了更改,但需要注意以下几点:安全性:在处理用户输入的
md.name时,确保其内容是安全的,避免 XSS 攻击。虽然使用了textContent来设置文本内容,但在其他地方可能存在未经过滤的用户输入。性能:使用
appendChild多次操作 DOM 可能会影响性能,尤其是在频繁更新的情况下。可以考虑使用文档片段(DocumentFragment)来减少重排和重绘。可维护性:建议将创建
chev的逻辑提取为一个单独的函数,以提高代码的可读性和可维护性。代码风格:确保代码风格与项目中其他部分一致,例如使用一致的缩进和空格。
综上所述,建议对这段代码进行修改以提高安全性和性能。