feat: DH-21757: WidgetPlugin support in deephaven.ui by mofojed · Pull Request #1341 · deephaven/deephaven-plugins

mofojed · 2026-04-27T21:52:21Z

WidgetPlugin just registers directly
- Allows for nested ui.resolve deephaven.ui components
Still maintain DashboardPlugin to handle legacy behaviour
Works with the ui_home_screen, nested dashboards, etc
Styling a little bit different (ui.panel is automatically wrapped in a nested dashboard rather than opening up panels in the existing dashboard like before)
- Keeps all components contained to a panel, rather than mixing with other components in the same dashboard
Dashboard now has a show_headers option that can be set to False to not show headers on a dashboard. Useful if you're doing a homescreen type dashboard

- Needs deephaven/web-client-ui#2648 - WidgetPlugin just registers directly - Allows for nested ui.resolve deephaven.ui components - Still maintain DashboardPlugin to handle legacy behaviour - Works with the ui_home_screen, nested dashboards, etc - Styling a little bit different (ui.panel is automatically wrapped in a nested dashboard rather than opening up panels in the existing dashboard like before) - Dashboard now has a `show_headers` option that can be set to False to not show headers on a dashboard. Useful if you're doing a homescreen type dashboard

- Add moduleNameMapper in jest.config.cjs to resolve React 18 from the plugin's local node_modules, fixing dual-React-instance errors - Mock usePersistentState in @deephaven/plugin mock to avoid FiberProvider dependency in tests - Update DocumentHandler test to reflect new behavior where non-layout children are rendered directly without ReactPanel wrapping

…ader

- Wrap bare (non-layout) widget children in DefaultPanelContent so they receive padding and surface widget loading/error states (fixes the ui_boom_counter error overlay not appearing after the WidgetPlugin refactor). - Add a styles.scss rule that strips the outer ReactPanel padding when its only child is a .dh-nested-dashboard, eliminating the duplicate padding around nested dashboards (e.g. ui_deeply_nested_dashboard).

- There's an issue here - when the ui.dashboard is the othermost thing, it should just take over the outer dashboard. Right now it's embeddign in. Need to fix that.

When a deephaven.ui widget is a single ui.panel hosted by the core WidgetPanel (e.g. opened via the WidgetPlugin in a code studio or in the embed widget scenario), render the panel's children inline using DefaultPanelContent instead of opening another GoldenLayout panel. Previously this produced a panel tab nested inside another panel tab. DefaultPanelContent now forwards the same View/Flex props that ReactPanel accepts so the user's ui.panel styling (padding, direction, gap, etc.) is preserved when rendered inline, and applies the dh-react-panel/dh-inner-react-panel class names so existing CSS rules (grid/chart padding strip, etc.) still apply. Also scope the nested-dashboard padding rule to .dh-react-panel so the outer WidgetPanel does not add extra padding around a top-level ui.dashboard in the embed widget scenario.

github-actions · 2026-04-27T21:58:00Z

ui docs preview (Available for 14 days)

- Shouldn't need to update all of these, there are likely some other fixes I need to do.

github-actions · 2026-04-29T01:15:12Z

ui docs preview (Available for 14 days)

github-actions · 2026-04-29T02:14:35Z

ui docs preview (Available for 14 days)

- now we don't have padding on the dashboard in the embed widget app scenario

github-actions · 2026-04-29T02:54:28Z

ui docs preview (Available for 14 days)

github-actions · 2026-04-29T14:51:48Z

ui docs preview (Available for 14 days)

github-actions · 2026-04-29T15:39:45Z

ui docs preview (Available for 14 days)

github-actions · 2026-05-04T18:49:27Z

ui docs preview (Available for 14 days)

- For the render-all pages, just load that widget up directly instead of opening it up in a nested panel.

github-actions · 2026-05-04T21:16:20Z

ui docs preview (Available for 14 days)

- This is consistent with how panels are opened in a dashboard without specifying a column or row (e.g. ui.dashboard([ui.panel(..), ui.panel(...)])). - Before it would just stack multiple panels when opening from a code studio, which was weird

- This was a fix in web-client-ui

github-actions · 2026-05-05T01:42:38Z

ui docs preview (Available for 14 days)

mofojed · 2026-05-05T13:20:03Z

I'm not sure why the "UI Table responds to props changes" tests have slightly changed. I need to look into this a bit to understand why.

…haven.ui-widget-plugin

github-actions · 2026-05-05T21:15:32Z

ui docs preview (Available for 14 days)

- In the ui_home_screen.py, we were re-declaring `_stocks` to be another variable, and were not using a ticking table - The ticking table was causing the snapshots to not match - This kind of points to an issue with app mode in general, where we need to be concious we're not overwriting other variables in other files. I'm choosing to ignore that at this time

github-actions · 2026-05-05T21:29:37Z

ui docs preview (Available for 14 days)

dsmmcken

Needs some docs, at least for the show headers

github-actions · 2026-05-06T19:05:23Z

ui docs preview (Available for 14 days)

margaretkennedy

Docs look good

dsmmcken

Are all the other e2e changes expected?

dsmmcken · 2026-05-08T17:47:07Z

+```
+
+> [!NOTE]
+> When `show_headers=False`, users will not be able to drag panels to rearrange the layout, since the header is the drag handle.


Suggested change

> When `show_headers=False`, users will not be able to drag panels to rearrange the layout, since the header is the drag handle.

> When `show_headers=False`, users will not be able to drag panels to rearrange the layout or change to other panels in a `ui.stack`, since the header is the target and drag handle.

Added stack caveat, I assume that's what would happen.

dsmmcken · 2026-05-08T17:56:32Z

+        "Value=i%2==0 ? `A` : `B`",
+        "Row=i",
+    ]
+)


You shouldn't use a timetable in e2e tests, you don't want anything ticking.

Though it doesn't look like the e2e tests display this, on screen. I think you should still switch it over so agents to follow it as a pattern.

mofojed added 12 commits April 27, 2026 09:40

Update types, remove duplicate types

16c6325

Cleanup after self-review

fd4c6f9

Fix up styling fix up tests

7258fab

fix: update e2e selectors from .dh-react-panel to .dh-panel.widget-lo…

022311d

…ader

package-lock updates

2ed7530

WIP update snapshots

5e71959

- There's an issue here - when the ui.dashboard is the othermost thing, it should just take over the outer dashboard. Right now it's embeddign in. Need to fix that.

Update some more snapshots...

d4f2271

WIP show a loading spinner when loading

def07ab

mofojed self-assigned this Apr 27, 2026

mofojed added 4 commits April 28, 2026 20:46

Fix jest config

5206dd3

fix: provide WidgetStatusContext in DocumentHandler tests

3c12046

Change up how things were named...

8985543

Remove updated snapshots...

1cd9196

- Shouldn't need to update all of these, there are likely some other fixes I need to do.

Get rid of dh-react-panel css on the defaultpanelcontent

5dc2ae0

mofojed mentioned this pull request Apr 29, 2026

feat: DH-21757: WidgetPlugin support in deephaven.ui #1326

Closed

Clean up some scss

0cf90fb

- now we don't have padding on the dashboard in the embed widget app scenario

Clean up some of the test selectors

eca77e8

Update ui loading spec

676c9aa

mofojed marked this pull request as ready for review April 29, 2026 15:36

mofojed requested review from a team and removed request for a team April 29, 2026 15:36

mofojed requested a review from vbabich April 29, 2026 15:36

Update a test that was referencing wrong panel type

1fe9308

mofojed force-pushed the DH-21757-resolve-deephaven.ui-widget-plugin branch from 96a9770 to 1fe9308 Compare May 4, 2026 18:45

Clean up some more tests

2c00340

- For the render-all pages, just load that widget up directly instead of opening it up in a nested panel.

mofojed added 3 commits May 4, 2026 21:34

Fix up wiring for the render all ui components tests

563f9d9

Update snapshots for multi-panel

3219d0a

- This is consistent with how panels are opened in a dashboard without specifying a column or row (e.g. ui.dashboard([ui.panel(..), ui.panel(...)])). - Before it would just stack multiple panels when opening from a code studio, which was weird

Update nested dashboard snapshots with correct active tab indicator

c721b22

- This was a fix in web-client-ui

Merge remote-tracking branch 'origin/main' into DH-21757-resolve-deep…

e901a09

…haven.ui-widget-plugin

dsmmcken requested changes May 5, 2026

View reviewed changes

docs: add show_headers example to dashboard docs

2364957

github-actions Bot requested a review from margaretkennedy May 6, 2026 18:09

mofojed added 3 commits May 6, 2026 14:19

Update architecture docs with some details

f0dbf6f

docs: add ui.resolve nested panel example to URI docs

2a26402

Add docs snapshots

b5987f8

margaretkennedy approved these changes May 7, 2026

View reviewed changes

mofojed requested a review from dsmmcken May 8, 2026 13:44

dsmmcken requested changes May 8, 2026

View reviewed changes

	> When `show_headers=False`, users will not be able to drag panels to rearrange the layout, since the header is the drag handle.
	> When `show_headers=False`, users will not be able to drag panels to rearrange the layout or change to other panels in a `ui.stack`, since the header is the target and drag handle.

Conversation

mofojed commented Apr 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 27, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented Apr 29, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 4, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

mofojed commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

github-actions Bot commented May 5, 2026

Uh oh!

dsmmcken left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions Bot commented May 6, 2026

Uh oh!

margaretkennedy left a comment

Choose a reason for hiding this comment

Uh oh!

dsmmcken left a comment

Choose a reason for hiding this comment

Uh oh!

dsmmcken May 8, 2026

Choose a reason for hiding this comment

Uh oh!

dsmmcken May 8, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

mofojed commented Apr 27, 2026 •

edited

Loading